Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BaseFeature serialisation behaviour regression #167

Closed
LachlanMcKee opened this issue Aug 9, 2022 · 1 comment · Fixed by #168
Closed

Fix BaseFeature serialisation behaviour regression #167

LachlanMcKee opened this issue Aug 9, 2022 · 1 comment · Fixed by #168

Comments

@LachlanMcKee
Copy link
Collaborator

The BaseFeature has a regression related to ordering when using a PostProcessor.

The behaviour previously (which is potentially a bug) would cause the PostProcessor to change the order of news events.

This change should be reverted (to avoid bugs), but also made configurable if that is the desired behaviour.

@LachlanMcKee
Copy link
Collaborator Author

After further investigation it turns out that this regression actually fixed an outstanding bug in MVICore. However for now until we update to a later version of Kotlin (due to the approach I will take to approach this fix), I will revert the change.

If you use a featureScheduler the behaviour change will be introduced, so it is a 'gotcha' for now. I will raise a new PR in the following days to make this behaviour fix opt-in

LachlanMcKee added a commit that referenced this issue Aug 10, 2022
[#167] Reverted BaseFeature PostProcessor recursion behaviour change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant