Extract binder from mvicore module #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaville
approved these changes
Jul 30, 2020
zsoltk
suggested changes
Jul 31, 2020
| @@ -8,6 +8,7 @@ group = 'com.github.badoo.mvicore' | |||
| dependencies { | |||
| def deps = rootProject.ext.deps | |||
|
|
|||
| api project(":binder") | |||
There was a problem hiding this comment.
To have available everywhere mvicore is added
Not sure if maven supports that, but it would be a nice first step before removing it completely
zsoltk
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binderis ideologically different from other pieces of functionality included in MVICore. Although it provides useful syntax and mechanics for linking hot sources together, ideally it should be a separate thing.This PR starts extraction by moving
Binderinto a different module while keeping MVICore dependent on it throughapidependency.