Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transformer from observable to observable #73

Merged
merged 14 commits into from May 30, 2019

Conversation

ShikaSD
Copy link
Contributor

@ShikaSD ShikaSD commented Apr 6, 2019

We have multiple cases in our codebase where we want transform element to multiple elements or apply some operators (throttling, distinct, etc) on it.
This PR allows transformer from element to observable.

@ShikaSD
Copy link
Contributor Author

ShikaSD commented Apr 6, 2019

@zsoltk please comment and review

@zsoltk
Copy link
Contributor

zsoltk commented Apr 8, 2019

Any strong reasons for Observable over list? Maybe both?

Also can we just use overloads of using? I feel usingObservable is somewhat misplaced.

@ShikaSD
Copy link
Contributor Author

ShikaSD commented Apr 8, 2019

@zsoltk

  1. Observable allows for more variations over list + we will still use flatMapIterable on it, why not use it directly.
  2. We cannot, because of generic erasure on lambda types, it considers both as a function over Function1.

@ShikaSD ShikaSD changed the title Allow transformer from element to observable Allow transformer from observable to observable May 20, 2019
@ShikaSD ShikaSD closed this May 30, 2019
@ShikaSD ShikaSD reopened this May 30, 2019
@zsoltk zsoltk merged commit f838267 into badoo:master May 30, 2019
@ShikaSD ShikaSD mentioned this pull request Jun 24, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants