Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special Characters in Links and Anchor Links - curl #11381 #36

Closed
jhauga opened this issue Jun 30, 2023 · 0 comments · Fixed by jhauga/roffit#7
Closed

Special Characters in Links and Anchor Links - curl #11381 #36

jhauga opened this issue Jun 30, 2023 · 0 comments · Fixed by jhauga/roffit#7

Comments

@jhauga
Copy link

jhauga commented Jun 30, 2023 •
edited
Loading

Description

  1. Special characters marked to be rendered as HTML link or anchor link do not render. This results in:
    • Duplicate anchor
      • -? is name="-"
    • Broken anchor link
      • -? is href="#-"
  2. Full inline urls (excluding indented as example) in nroff file followed by a punctuation character will produce:
    • Unwanted link
      • "http://"
    • Broken link
      • "https://example.com"

Priority - Very Minor

This is a very minor issue. Please put to the bottom of your priorities. It is based upon curl issue #11381.
@jhauga jhauga mentioned this issue Jun 30, 2023
Closed
4 tasks
jhauga added a commit to jhauga/roffit that referenced this issue Jul 8, 2023
@jhauga
Special Characters and Broken Links
985a41f 
# Pull Summary
Special Characters and Links: 2 scripts added, and Makefile edited.

This pull request contains **"jhauga-resolveOptionLinks"** branch with:
1. Two supporting script files added that edit .dump file after 
nroff build. 
2. Makefile edited to run two supporting scripts after build. 
3. Example folder with proof of concept of support scripts used 
in Makefile.

## Branch Summary - jhauga-resolveOptionLinks
Files added/edited:
1. Makefile
   - Line 28 - \@.\/fixSpecialCharacters.sh
   - Line 29 - \@.\/fixBrokenLinks.sh
2. fixSpecialCharacters.sh
   - Prompts for input, asking if ther are options with special characters.
   - If so will run several "sed" statements to replace accordingly.
   - Provides additional variable (*commented out*) for custom generation.
3. fixBrokenLinks.sh
   - fixes encoded html characters rendered by noffit that cause broken links.
   - Voids (*javascript:coid(0)*) unwanted links.
4. examples_DELETE_ME
   - Example folder with proof of concept of supporting scripts used in Makefile.
   - For more details see **"README.md"** included in folder.

## Resolves
This pull request will resolve:
1. [roffit issue bagder#36](bagder#36)
2. [curl issue #11381](curl/curl#11381)
@jhauga jhauga mentioned this issue Jul 8, 2023
Merged
jhauga added a commit to jhauga/roffit that referenced this issue Jul 8, 2023
@jhauga
Merge pull request #1 from jhauga/jhauga-resolveOptionLinks
6cf7c2e 
Special Characters and Links: 2 scripts added, and Makefile edited.

This pull request contains **"jhauga-resolveOptionLinks"** branch with:
1. Two supporting script files added that edit .dump file after 
nroff build. 
2. Makefile edited to run two supporting scripts after build. 
3. Example folder with proof of concept of support scripts used 
in Makefile.

This pull request will resolve:
1. [roffit issue bagder#36](bagder#36)
2. [curl issue #11381](curl/curl#11381)
@jhauga jhauga mentioned this issue Jul 8, 2023
Closed
@jhauga jhauga mentioned this issue Jul 21, 2023
Merged
@ghost ghost mentioned this issue Jul 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roffit: fix special characters and broken links jhauga/roffit
1 participant
@jhauga