Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There should not be sale icon in shopping cart in velocity theme #3689

Closed
bhanu-webkul opened this issue Aug 7, 2020 · 2 comments
Closed

There should not be sale icon in shopping cart in velocity theme #3689

bhanu-webkul opened this issue Aug 7, 2020 · 2 comments
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.

Comments

@bhanu-webkul
Copy link

Bug report

Title

There should not be sale icon in shopping cart

Preconditions

1. framework Version. Master

Steps to reproduce

1. step1: create a product with special price 
2. step2: add to cart that product and view cart

Expected result:

No need to display sale icon in shopping cart

Actual result

https://prnt.sc/tvmsex
@vaishaliwebkul vaishaliwebkul added the Bug Something isn't working. label Aug 7, 2020
@bhanu-webkul
Copy link
Author

https://prnt.sc/tvnksa

rahulcs0082 added a commit to rahulcs0082/bagisto that referenced this issue Aug 7, 2020
@rahulcs0082
Issue bagisto#3689 and 3674 fixed
025c761
@rahulcs0082 rahulcs0082 mentioned this issue Aug 7, 2020
Merged
@jitendra-webkul jitendra-webkul added the Bug Fixed When bug issue is fixed. label Aug 10, 2020
jitendra-webkul added a commit that referenced this issue Aug 10, 2020
@jitendra-webkul
Merge pull request #3690 from rahulcs0082/development
94135f9 
Issue #3689 and 3674 fixed
@bhanu-webkul
Copy link
Author

Fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jitendra-webkul @vaishaliwebkul @bhanu-webkul @devansh-webkul