Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trimming should be added for the search string. #6644

Closed
Sanjaybhattwebkul opened this issue Aug 17, 2022 · 1 comment
Closed

Trimming should be added for the search string. #6644

Sanjaybhattwebkul opened this issue Aug 17, 2022 · 1 comment
Assignees
@papnoisanjeev
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.
Milestone
1.4.4

Comments

@Sanjaybhattwebkul
Copy link
Contributor

Bagisto Version: Master

Steps To reproduce--

1. Log in as an admin.
2. Click on the products inside the catalog
3. Try to search for any product after adding a space after the search string.

Expected result: Trimming should be added for the search string.

Actual result: The search functionality not working if there is any space on the searching string. Please find the below screenshot.

error-two

error-one
@Sanjaybhattwebkul Sanjaybhattwebkul added the Bug Something isn't working. label Aug 17, 2022
@Sanjaybhattwebkul Sanjaybhattwebkul added this to the 1.4.4 milestone Aug 17, 2022
@papnoisanjeev papnoisanjeev mentioned this issue Aug 17, 2022
Merged
@Sanjaybhattwebkul Sanjaybhattwebkul added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label Aug 17, 2022
jitendra-webkul added a commit that referenced this issue Aug 23, 2022
@jitendra-webkul
Merge pull request #6645 from papnoisanjeev/search-bar-issue-with-whi…
f704f79 
…tespace

Search bar issue with white space #6644
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Fixed When bug issue is fixed. and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Aug 25, 2022
@Sanjaybhattwebkul
Copy link
Contributor Author

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@papnoisanjeev papnoisanjeev

Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
2 participants
@papnoisanjeev @Sanjaybhattwebkul