Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also kill child processes of server #3

Merged
merged 3 commits into from Mar 14, 2018

Conversation

@dallonf
Copy link
Contributor

@dallonf dallonf commented Mar 13, 2018

In some cases (real-world example: create-react-app), a server is started in a child process. If only the parent process is killed, the actual server will still be opened (and taking up the port!)

This should fix that. Try npm run demo3 and make sure nothing is open on port 9000 after the tests are done.

@bahmutov
Copy link
Owner

@bahmutov bahmutov commented Mar 14, 2018

nice, ps-tree is the solution, thank you for this!

@bahmutov bahmutov merged commit ce26532 into bahmutov:master Mar 14, 2018
1 check passed
@dallonf dallonf deleted the feature/kill-child-processes branch Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants