Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] l10n: There are no text strings in Transifex #146

Closed
Valdnet opened this issue Feb 11, 2022 · 12 comments · Fixed by nextcloud/docker-ci#355
Closed

[EN] l10n: There are no text strings in Transifex #146

Valdnet opened this issue Feb 11, 2022 · 12 comments · Fixed by nextcloud/docker-ci#355
Assignees

Comments

@Valdnet
Copy link
Contributor

Valdnet commented Feb 11, 2022

1. The following text strings are missing from Transifex:

showSuccess(t('gestion', 'Modification saved'));

showMessage(t('gestion', 'Modification saved'));

showMessage(t('gestion', 'Save in') + " " + $("#theFolder").val() + "/" + $("#pdf").data("folder"));

showMessage(t('gestion', 'There is an error'));

return "<option selected value='0'>" + t('gestion', 'disable') + "</option><option value='1'>" + t('gestion', 'enable') + "</option>"

return "<option value='0'>" + t('gestion', 'disable') + "</option><option selected value='1'>" + t('gestion', 'enable') + "</option>"

2. Change text strings:

disable -> Disable
enable -> Enable

3. All text strings from mainFunction.mjs are also missing.

obraz

obraz

@Valdnet Valdnet changed the title l10n: There are no text strings in Transifex [EN] l10n: There are no text strings in Transifex Feb 11, 2022
@baimard
Copy link
Owner

baimard commented Feb 11, 2022

Thank you for repporting ! I will have a look

@baimard
Copy link
Owner

baimard commented Feb 12, 2022

All translations from mjs module not work, maybe transifex problem ?

@Valdnet
Copy link
Contributor Author

Valdnet commented Feb 12, 2022

This seems to be a problem on the repository.
@rakekniven what do you think?

@rakekniven
Copy link
Contributor

AFAIK "mjs" is not a supported file extension. Where are these files from?

@baimard
Copy link
Owner

baimard commented Feb 13, 2022

AFAIK "mjs" is not a supported file extension. Where are these files from?

JavaScript Module :(

@baimard
Copy link
Owner

baimard commented Feb 14, 2022

For transifex it's a bug or features ?

@rakekniven
Copy link
Contributor

Not sure if this is related with Transifex or the CI tools/scripts of Nextcloud. Let me check this but I am short in time today.

@baimard
Copy link
Owner

baimard commented Feb 14, 2022

not a problem i'm short too. Do it when you have time :)

rakekniven added a commit to nextcloud/docker-ci that referenced this issue Feb 16, 2022
Fixes #354 

Should fix baimard/gestion#146 as well.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@baimard
Copy link
Owner

baimard commented Feb 23, 2022

Thanks you @rakekniven

@baimard
Copy link
Owner

baimard commented Mar 10, 2022

nextcloud/docker-ci#362

@nickvergessen
Copy link

Works now
Bildschirmfoto von 2022-03-10 10-50-49

@baimard
Copy link
Owner

baimard commented Mar 10, 2022

@nickvergessen this is a very good news, thank you for the work and for your time.

@baimard baimard closed this as completed Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants