Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file extension "mjs" to list of translatable files #355

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

rakekniven
Copy link
Member

Fixes #354

Should fix baimard/gestion#146 as well.

Signed-off-by: rakekniven 2069590+rakekniven@users.noreply.github.com

Fixes #354 

Should fix baimard/gestion#146 as well.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@rakekniven rakekniven merged commit 2ba4df6 into master Feb 17, 2022
@rakekniven rakekniven deleted the rakekniven-patch-1 branch February 17, 2022 18:50
@rakekniven
Copy link
Member Author

Hello @nickvergessen ,

does this PR needs to be deployed somewhere after it has been merged?
I cannot see source strings appearing (see linked issue from initial post) at Transifex.

@nickvergessen
Copy link
Member

Yes i guess so.
Ill have a look this week. I also have an error from logreader coming in daily as a reminder

@nickvergessen
Copy link
Member

Deployed and triggered manually.

@rakekniven
Copy link
Member Author

No new strings from mjs as source files this morning.

@rakekniven
Copy link
Member Author

@nickvergessen This PR has been closed. But the strings from MJS files are still missing.
As there is no issue for this I am kindly asking for help to solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

l10n: Add mjs to list of javascript filename extensions [EN] l10n: There are no text strings in Transifex
2 participants