Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor input/output types #232

Merged
merged 51 commits into from
Aug 16, 2023
Merged

Refactor input/output types #232

merged 51 commits into from
Aug 16, 2023

Conversation

sujuka99
Copy link
Contributor

@sujuka99 sujuka99 commented Jun 7, 2023

closes #119

@sujuka99 sujuka99 self-assigned this Jun 7, 2023
@sujuka99
feat: Allow empty topic definitions, infer topics type
be863ef
@sujuka99
Merge remote-tracking branch 'origin/main' into refactor/input-output…
3a14350 
…-types
@sujuka99
chore: polish and clean up
56dc07b
@sujuka99
chore: update poetry version in CI
13802de
@sujuka99
Merge remote-tracking branch 'origin/main' into refactor/input-output…
b9cd890 
…-types
@sujuka99
Merge remote-tracking branch 'origin/main' into refactor/input-output…
0bd4736 
…-types
@sujuka99
chore: update schema
11cb62a
@sujuka99
Merge remote-tracking branch 'origin/main' into refactor/input-output…
a514af7 
…-types
@sujuka99
chore: pass tests
43cfcf2
@sujuka99
docs: update
5b681c9
@sujuka99
feat: enable type inference for components
1e64a6f
@sujuka99
docs(examples): Update to reflect the introduced feature
5b860b6
@sujuka99
Merge remote-tracking branch 'origin/main' into refactor/input-output…
c3d9632 
…-types
@sujuka99
style: update docstr
16468cb
@sujuka99 sujuka99 marked this pull request as ready for review June 14, 2023 11:56
disrupted
disrupted requested changes Jun 14, 2023
View reviewed changes
tests/pipeline/test_pipeline.py Outdated Show resolved Hide resolved
tests/pipeline/resources/pipeline-with-short-topics/pipeline.yaml Outdated Show resolved Hide resolved
kpops/components/base_components/models/to_section.py Outdated Show resolved Hide resolved
@raminqaf raminqaf added breaking-change Indicates that this PR introduces a breaking change type/refactor Refactoring of existing functionality labels Jul 7, 2023
@disrupted disrupted added this to the v2.0 milestone Aug 1, 2023
@disrupted disrupted requested a review from irux as a code owner August 8, 2023 08:01
@sujuka99 sujuka99 changed the base branch from main to v2 August 15, 2023 07:53
philipp94831
philipp94831 requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@philipp94831 philipp94831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the way the result turned out

docs/docs/resources/pipeline-components/kafka-app.yaml Outdated Show resolved Hide resolved
tests/pipeline/resources/pipeline-with-short-topics/defaults.yaml Outdated Show resolved Hide resolved
disrupted
disrupted previously requested changes Aug 15, 2023
View reviewed changes
kpops/components/base_components/models/from_section.py Outdated Show resolved Hide resolved
kpops/components/base_components/models/to_section.py Outdated Show resolved Hide resolved
disrupted
disrupted approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sujuka99 sujuka99 merged commit 4290da1 into v2 Aug 16, 2023
5 checks passed
@sujuka99 sujuka99 deleted the refactor/input-output-types branch August 16, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp94831 philipp94831 philipp94831 approved these changes

@disrupted disrupted disrupted approved these changes

@raminqaf raminqaf Awaiting requested review from raminqaf

@irux irux Awaiting requested review from irux

Assignees

@sujuka99 sujuka99

Labels
breaking-change Indicates that this PR introduces a breaking change type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Refactor input/output types
4 participants
@sujuka99 @philipp94831 @disrupted @raminqaf