Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create init command #394

Merged
merged 42 commits into from
Mar 7, 2024
Merged

Create init command #394

merged 42 commits into from
Mar 7, 2024

Conversation

sujuka99
Copy link
Contributor

@sujuka99 sujuka99 self-assigned this Dec 20, 2023
@sujuka99 sujuka99 changed the base branch from main to v3 December 21, 2023 09:52
Base automatically changed from v3 to main January 17, 2024 12:58
@sujuka99 sujuka99 marked this pull request as ready for review February 28, 2024 08:01
disrupted
disrupted requested changes Feb 28, 2024
View reviewed changes
docs/docs/user/references/cli-commands.md Outdated Show resolved Hide resolved
docs/docs/user/references/cli-commands.md Outdated Show resolved Hide resolved
kpops/cli/main.py Outdated Show resolved Hide resolved
disrupted
disrupted reviewed Feb 29, 2024
View reviewed changes
kpops/utils/yaml.py Outdated Show resolved Hide resolved
kpops/utils/json.py Outdated Show resolved Hide resolved
kpops/utils/yaml.py Outdated Show resolved Hide resolved
tests/utils/test_cli_commands.py Outdated Show resolved Hide resolved
disrupted
disrupted reviewed Feb 29, 2024
View reviewed changes
tests/utils/test_cli_commands.py Outdated Show resolved Hide resolved
tests/utils/test_cli_commands.py Outdated Show resolved Hide resolved
disrupted
disrupted reviewed Mar 1, 2024
View reviewed changes
kpops/utils/cli_commands.py Outdated Show resolved Hide resolved
kpops/utils/yaml.py Outdated Show resolved Hide resolved
@sujuka99 @disrupted
Remove parentheses
5d1f830 
Co-authored-by: Salomon Popp <salomon.popp@bakdata.com>
disrupted
disrupted reviewed Mar 6, 2024
View reviewed changes
tests/cli/test_init.py Outdated Show resolved Hide resolved
@sujuka99 sujuka99 merged commit 2624aec into main Mar 7, 2024
8 of 9 checks passed
@sujuka99 sujuka99 deleted the feat/kpops-init branch March 7, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

@raminqaf raminqaf Awaiting requested review from raminqaf raminqaf is a code owner

@irux irux Awaiting requested review from irux

Assignees

@sujuka99 sujuka99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sujuka99 @disrupted