Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribute defaults across multiple files #438

Merged
merged 48 commits into from
Feb 27, 2024
Merged

Distribute defaults across multiple files #438

merged 48 commits into from
Feb 27, 2024

Conversation

raminqaf
Copy link
Contributor

Closes #55

@raminqaf raminqaf self-assigned this Jan 26, 2024
@raminqaf raminqaf added type/enhancement New feature or request component/generator Related to the generation of pipeline.yaml component/cli Related to the CLI commands breaking-change Indicates that this PR introduces a breaking change labels Jan 26, 2024
@raminqaf raminqaf mentioned this pull request Jan 30, 2024
Merged
@raminqaf raminqaf marked this pull request as ready for review January 31, 2024 08:16
disrupted
disrupted reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this calls for a new migration guide :)

@disrupted disrupted added this to the v4.0 milestone Jan 31, 2024
disrupted
disrupted reviewed Jan 31, 2024
View reviewed changes
kpops/pipeline.py Outdated Show resolved Hide resolved
disrupted
disrupted reviewed Feb 12, 2024
View reviewed changes
kpops/pipeline.py Outdated Show resolved Hide resolved
disrupted
disrupted previously approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but perhaps wait for the CI fix @sujuka99 is working on before actually merging

@raminqaf
Log picked up files in verbose mode (#437)
8eb3232 
Closes #268 
Depends on #438 
The output looks like this when running KPOps with the `--verbose`
command:
```console
Yaml - Picked up: config.yaml
Registry - Picked up: tests/pipeline/test_components/__init__.py
Yaml - Picked up: tests/pipeline/resources/pipeline-with-env-defaults/pipeline.yaml
Yaml - Picked up: tests/pipeline/resources/pipeline-with-env-defaults/defaults_development.yaml
Yaml - Picked up: tests/pipeline/resources/pipeline-with-env-defaults/defaults.yaml
BaseDefaultsComponent - Found defaults for component type streams-app in tests/pipeline/resources/pipeline-with-env-defaults/defaults.yaml
Yaml - Picked up: tests/pipeline/resources/defaults.yaml
BaseDefaultsComponent - Found defaults for component type streams-app in tests/pipeline/resources/defaults.yaml
Yaml - Picked up: tests/pipeline/defaults.yaml
BaseDefaultsComponent - Found defaults for component type kafka-app in tests/pipeline/resources/pipeline-with-env-defaults/defaults.yaml
BaseDefaultsComponent - Found defaults for component type kafka-app in tests/pipeline/resources/defaults.yaml
BaseDefaultsComponent - Found defaults for component type kubernetes-app in tests/pipeline/resources/pipeline-with-env-defaults/defaults_development.yaml
BaseDefaultsComponent - Found defaults for component type kubernetes-app in tests/pipeline/resources/pipeline-with-env-defaults/defaults.yaml
BaseDefaultsComponent - Found defaults for component type kubernetes-app in tests/pipeline/resources/defaults.yaml
BaseDefaultsComponent - Found defaults for component type kubernetes-app in tests/pipeline/defaults.yaml
BaseDefaultsComponent - Found defaults for component type pipeline-component in tests/pipeline/resources/defaults.yaml
BaseDefaultsComponent - Enriching component of type streams-app
[...]
```
@raminqaf raminqaf merged commit b5fdbc8 into main Feb 27, 2024
6 of 7 checks passed
@raminqaf raminqaf deleted the feature/distribute-defaults branch February 27, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

@irux irux Awaiting requested review from irux

@sujuka99 sujuka99 Awaiting requested review from sujuka99

Assignees

@raminqaf raminqaf

Labels
breaking-change Indicates that this PR introduces a breaking change component/cli Related to the CLI commands component/generator Related to the generation of pipeline.yaml type/enhancement New feature or request
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

Defaults should be distributed across multiple files
3 participants
@raminqaf @disrupted @sujuka99