Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lands #75

Closed
Angeschossen opened this issue Sep 1, 2021 · 4 comments
Closed

Lands #75

Angeschossen opened this issue Sep 1, 2021 · 4 comments

Comments

@Angeschossen
Copy link
Contributor

Angeschossen commented Sep 1, 2021

Description (Required)

Is there any way to pass the actual plugin that uses dough, to the constructor of the Lands integration class in the protection module? It requires this, for flags etc.

https://github.com/baked-libs/dough/blob/fc572efd6c0042310156bba7d9f4516c8406c926/dough-protection/src/main/java/io/github/bakedlibs/dough/protection/ProtectionManager.java#L72

Here is the actual problem:
plugin = Lands, but it should be = plugin that uses dough
https://github.com/baked-libs/dough/blob/fc572efd6c0042310156bba7d9f4516c8406c926/dough-protection/src/main/java/io/github/bakedlibs/dough/protection/modules/LandsProtectionModule.java#L34

I haven't looked through the complete repo, but maybe passing the actual plugin to the constructor of the protection module manager would be an idea?

@WalshyDev
Copy link
Member

Yeah, that is a good idea. Not exactly sure why it's done this way currently

@Angeschossen
Copy link
Contributor Author

Any update on this? Should I open a PR?

@J3fftw1
Copy link
Contributor

J3fftw1 commented Sep 24, 2021

Yea you can open a pr

Angeschossen pushed a commit to Angeschossen/dough that referenced this issue Nov 1, 2021
@WalshyDev
Copy link
Member

WalshyDev commented Jan 10, 2022

Fix has been merged - #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants