-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lands #75
Comments
Yeah, that is a good idea. Not exactly sure why it's done this way currently |
Any update on this? Should I open a PR? |
Yea you can open a pr |
Angeschossen
pushed a commit
to Angeschossen/dough
that referenced
this issue
Nov 1, 2021
Merged
Fix has been merged - #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description (Required)
Is there any way to pass the actual plugin that uses dough, to the constructor of the Lands integration class in the protection module? It requires this, for flags etc.
https://github.com/baked-libs/dough/blob/fc572efd6c0042310156bba7d9f4516c8406c926/dough-protection/src/main/java/io/github/bakedlibs/dough/protection/ProtectionManager.java#L72
Here is the actual problem:
plugin = Lands, but it should be = plugin that uses dough
https://github.com/baked-libs/dough/blob/fc572efd6c0042310156bba7d9f4516c8406c926/dough-protection/src/main/java/io/github/bakedlibs/dough/protection/modules/LandsProtectionModule.java#L34
I haven't looked through the complete repo, but maybe passing the actual plugin to the constructor of the protection module manager would be an idea?
The text was updated successfully, but these errors were encountered: