Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #75 #93

Merged
merged 8 commits into from
Jan 7, 2022
Merged

Fix issue #75 #93

merged 8 commits into from
Jan 7, 2022

Conversation

Angeschossen
Copy link
Contributor

This pull requests fixes issue #75.
The ProtectionManager class now requires the plugin instance that uses dough.

Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the PR, tiny fixes

Angeschossen and others added 2 commits November 1, 2021 16:46
…ction/ProtectionManager.java


Spacing

Co-authored-by: Daniel Walsh <walshydev@gmail.com>
…ction/modules/LandsProtectionModule.java


var spacing

Co-authored-by: Daniel Walsh <walshydev@gmail.com>
@TheBusyBiscuit TheBusyBiscuit linked an issue Dec 20, 2021 that may be closed by this pull request
Copy link
Member

@Sfiguz7 Sfiguz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside one thing

*/
@SuppressWarnings("java:S1612")
public ProtectionManager(@Nonnull Server server) {
public ProtectionManager(@Nonnull Server server, @Nonnull Plugin plugin) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of this being named plugin but can't think of a better name ccurrently

@Sfiguz7 Sfiguz7 self-assigned this Jan 7, 2022
@WalshyDev WalshyDev self-assigned this Jan 7, 2022
@WalshyDev WalshyDev merged commit 2ca1f21 into Slimefun:main Jan 7, 2022
@WalshyDev WalshyDev mentioned this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lands protection not loading
4 participants