-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #75 #93
Fix issue #75 #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the PR, tiny fixes
...ection/src/main/java/io/github/bakedlibs/dough/protection/modules/LandsProtectionModule.java
Outdated
Show resolved
Hide resolved
dough-protection/src/main/java/io/github/bakedlibs/dough/protection/ProtectionManager.java
Outdated
Show resolved
Hide resolved
…ction/ProtectionManager.java Spacing Co-authored-by: Daniel Walsh <walshydev@gmail.com>
…ction/modules/LandsProtectionModule.java var spacing Co-authored-by: Daniel Walsh <walshydev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside one thing
*/ | ||
@SuppressWarnings("java:S1612") | ||
public ProtectionManager(@Nonnull Server server) { | ||
public ProtectionManager(@Nonnull Server server, @Nonnull Plugin plugin) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big fan of this being named plugin
but can't think of a better name ccurrently
This pull requests fixes issue #75.
The ProtectionManager class now requires the plugin instance that uses dough.