-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RGBA support #13
base: master
Are you sure you want to change the base?
Add RGBA support #13
Conversation
This certainly simplifies the alpha patch a great deal. Will have to do a more in-depth review given that what is here is not what you'd get with the normal alpha patch. There may be a few edge cases to consider like when using short RGB codes like #ccc or named colours like "magenta". |
My personal opinion on the short names is that they should be deemed invalid. This PR behaves in the following way, currently:
This keeps the code-base simple and clear. |
Have you considered the fact that this also break literal color names such as "white"/"black" etc ? Because colornames aren't limited to hex values as of now. P.S: Just noticed that bakkeby already bought up the issue with named colors. |
For this patch to be feasible, what improvements do you guys think I should make? |
Maybe this is better as a candidate patch on the suckless pages page? I did play around with something similar for dwm and my experience with it is that although it works it is kind of annoying to maintain alpha values on a per individual colour code basis, especially when you are using Xresources. |
This PR removes the alphas array and implements RGBA support.