CSV Payouts MVP

[kleinsch]

Since the CSV upload has turned into a fairly complicated project, I'd like to start with a bare-bones MVP to test out the technology and workflow. Here are the steps we'll support for this task:

1. User clicks (newly added) Pay Multiple Sellers button, located under the existing Pay Seller button.

2. User is taken to a page (not a modal) that prompts them to upload a CSV file of existing customers and existing bank accounts. For this task, we're not going to worry about creating new customers or bank accounts. We don't have a visual design for this screen yet, so bare-bones functional UI is fine.
3. User uploads a CSV file and clicks Submit
4. System processes the CSV file and issues payouts. There's no error handling other than checking it's a valid CSV file and parsing out the necessary data - for this task I don't want to get bogged down in error checking/handling.
5. User is taken to the marketplace activity page - which will have the newly created credits.

[kleinsch]

@zachgersh - this task is for you. :) I don't want to keep you waiting on design for the ultimate feature and have it end up being a giant daunting project, so we'll start small, then add functionality/design later.

For an example of how to credit an existing bank account, take a look at credit_bank_account_modal.js.

I think this should be enough for you to get started, let me know if you've got any questions!

[zachgersh]

YES! THIS IS AWESOME.

[zachgersh]

As a side note, I am definitely working on this :)

Just been a bit hectic these last few weeks!

[zachgersh]

Hey @kleinsch,

When creating the credit can I actually verify via the fixture browser that everything is happening successfully? I am currently logging that the credit got created successfully but I never see the escrow balance update in the test environment.

How should I go about verifying this :(

[mjallday]

@zachgersh what's the state on the credit? if it's failed then the escrow will not have updated.

if that's not the case can you give us the marketplace uri for the marketplace in question and the credit and we'll take a look.

[zachgersh]

Hey @mjallday,

Great to be speaking with you! I logged the object and I believe it said it had succeeded (I think that comes back in the response).

I am using what I believe is called Nick's Test Marketplace in the fixture browser. I don't have the project running at present but I figured you could grab the URI since it would be the same on your end when running the fixtures :D

[mjallday]

The tests should be creating a new marketplace on each run so I'm not sure if I'll be able to see your marketplace.

I'm a little rusty with the fixture browser, can you provide instructions on how to reproduce this particular issue?

Feel free to jump on #balanced on freenode IRC if you want to chat in real-time about this.

[zachgersh]

Sure thing!

I am not actually running the test suite at present (Since this is just a
proof of concept). I am actually just running a grunt server (grunt) and
then going to the URL you all provided once everything has loaded:

http://localhost:9876/build/test/fixturebrowser.html

That loads up the test marketplace that has data in it. I was assuming
that I could manipulate the data in that test marketplace but maybe not.

On Tue, Nov 5, 2013 at 9:14 AM, Marshall Jones notifications@github.comwrote:

The tests should be creating a new marketplace on each run so I'm not sure
if I'll be able to see your marketplace.

I'm a little rusty with the fixture browser, can you provide instructions
on how to reproduce this particular issue?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/700#issuecomment-27792465
.

[mjallday]

That's probably it. I doubt the fixtures allow for any interactive stuff since there's no dependencies between them.

If I were you I would fire up the actual site and create a test marketplace and create some test transactions. If you run the test suite and grab the API key for the marketplace it creates as part of the test run you should be able to access all the transactions it creates as part of the test run.

[zachgersh]

Hey @mjallday

Thanks so much for the feedback but it seems like an iffy way to test the functionality? I would assume that the fixture browser would still interact with the fixtures and let me modify them via the Balanced methods that are available.

[mjallday]

That would require us to write logic in the fixture client to manipulate state and maintain dependencies between fixtures. To me that sounds like a lot of work and maintenance.

If you think that's a good feature however, please open a separate ticket where we can discuss and debate the merits of doing so. It may be easier than I suspect!

[dmdj03]

#21