Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #95

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Refactor tests #95

merged 7 commits into from
Sep 21, 2023

Conversation

johngrantuk
Copy link
Member

  • Refactor join/exit tests to make it easier to follow
  • Fix native asset test on join
  • Fix native asset handling on join

brunoguerios
brunoguerios approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@brunoguerios brunoguerios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor. It's way better! 😃

test/weightedJoin.integration.test.ts Outdated Show resolved Hide resolved
test/weightedJoin.integration.test.ts Outdated Show resolved Hide resolved
@johngrantuk johngrantuk merged commit 346cb9d into exit Sep 21, 2023
3 of 4 checks passed
@johngrantuk johngrantuk deleted the refactor-tests branch September 21, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoguerios brunoguerios brunoguerios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johngrantuk @brunoguerios