Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add goerli dvt token #56

Merged
merged 7 commits into from
Apr 22, 2023
Merged

add goerli dvt token #56

merged 7 commits into from
Apr 22, 2023

Conversation

jianlinjiang
Copy link
Contributor

No description provided.

@jianlinjiang
Copy link
Contributor Author

@garethfuller hello, I follow the page balancer/frontend-v2/wiki to add add tokens to tokenlist. Please review the pull request and merge the branch to the master. Thank you very much!

@zekraken-bot
Copy link
Collaborator

@jianlinjiang, you need to add a comma to the end of the address you added, also were you planning on adding a token image?

@jianlinjiang
Copy link
Contributor Author

@zekraken-bot thanks for your comment. I add a comma in the new commit, and please review the pull request. Token image: https://user-images.githubusercontent.com/78342319/231230043-e0ea1785-ed32-498a-805e-496908c0e7ae.png. How can I add the image url to the repository?

@zekraken-bot
Copy link
Collaborator

@jianlinjiang you'll want to add a .png file of the token image to this path https://github.com/balancer/tokenlists/tree/zekraken/src/assets/images/tokens make sure the address is in all lowercase

@jianlinjiang
Copy link
Contributor Author

@zekraken-bot I added a new commit which adds the dvt token image. Please review the pull request, thank you!

@zekraken-bot
Copy link
Collaborator

@jianlinjiang you've got to make sure the image file is lowercase characters only.. also you are aware you are only whitelisting for the testnet, correct?

@jianlinjiang
Copy link
Contributor Author

@zekraken-bot I've renamed the token image file, and add main token address. Please review the commits, thank you.

@zekraken-bot zekraken-bot merged commit 0c61091 into balancer:main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants