Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill and hold reset while holding. #1

Closed
lovrozagar opened this issue Oct 24, 2023 · 2 comments
Closed

Fill and hold reset while holding. #1

lovrozagar opened this issue Oct 24, 2023 · 2 comments

Comments

@lovrozagar
Copy link

Hello 😃, really appreciate your work on this package.

Opening the first issue related to the fill and hold functionality. While holding the button down sometimes the ripple will disappear and fire immediately after, please try the green button in demo: https://balazs-topg.github.io/react-ripples-continued/

Thanks.

@balazshevesi
Copy link
Owner

Hey, thanks!
I knew of this while developing it, but i couldn't seem to find the cause. In my experience it pretty much never happens as long as you're using chrome and not using the "optimize" prop. I will look into it again

@balazshevesi balazshevesi pinned this issue Oct 24, 2023
balazshevesi added a commit that referenced this issue Oct 25, 2023
@balazshevesi
Copy link
Owner

fixed it. turns out it was a problem with relying on keyframe-animations, i removed the css file entirely, now it's relying just on transitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants