This repository has been archived by the owner on Aug 6, 2021. It is now read-only.
Update Lifecyclecallbacks.md with error handling #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear advice about making sure thrown errors or rejections make it back to the callback and why.
|
LGTM! |
|
Thanks @ashleysimons ! |
mikermcneil
reviewed
Nov 16, 2017
|
|
||
| It's important to realize that Sails will not catch thrown errors in your callbacks. If there is any chance the code you are executing will throw an `Error`, please wrap it in a `try catch` and pass the error to the callback. |
There was a problem hiding this comment.
Can we clarify "in lifecycle callbacks" here?
| @@ -67,6 +67,33 @@ module.exports = { | |||
| }; | |||
| ``` | |||
|
|
|||
| ### Error handling ### | |||
There was a problem hiding this comment.
Can we trim the extra set of ###- it could confuse our doctemplater tool
| } | ||
| ``` | ||
|
|
||
| If you are using promises, please define a `catch` and pass the error to the callback. A promise will swallow the error. |
There was a problem hiding this comment.
Can we replace this with an async/await example?
|
@ashleysimons Reverted in #936 but would love to remerge if you wouldn't mind making the changes above Also, would you make the changes against the 1.0 branch? Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear advice about making sure thrown errors or rejections make it back to the callback and why.