MySQL connection.wlNext.caseSensitive propagates up to waterline-sequel #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue #255 and #303 |
|
Ah shoot, failing tests. BRB |
|
@particlebanana This is working very well for me in production, upstream is failing tests though. |
|
@wulfsolter re-ran the tests after some changes and everything looks good as far as that goes now. Looking into the PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
config/connections.jsto define case-sensitive MySQL queries.Thanks to @shamasis on postmanlabs@d8bcd07 with a little tweak to keep the connector config same as with sails-postgresql (https://github.com/balderdashy/sails-postgresql/issues/142#issuecomment-88680201)