fix RangeError: Maximum call stack size exceeded] error

balderdashy · Feb 12, 2015 · 4a52a3b · 4a52a3b
1 parent f1d01e3
commit 4a52a3b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ### master
 
+* [BUGFIX] Fix [RangeError: Maximum call stack size exceeded] error in PubSub hook
 * [ENHANCEMENT] Support layout for Ractive template engine
 
 

diff --git a/lib/hooks/pubsub/index.js b/lib/hooks/pubsub/index.js
@@ -168,6 +168,10 @@ module.exports = function(sails) {
           var id = record[this.primaryKey] || record;
           // Get the socket room to publish to
           var room = this.room(id, "message");
+
+          // Ensure that we're working with a clean, unencumbered object
+          data = _.cloneDeep(data);
+
           // Create the payload
           var payload = {
             verb: "messaged",
@@ -537,7 +541,7 @@ module.exports = function(sails) {
         options = options || {};
 
         // Ensure that we're working with a clean, unencumbered object
-        changes = _.clone(changes);
+        changes = _.cloneDeep(changes);
 
         // Enforce valid usage
         var validId = _.isString(id) || _.isFinite(id);