-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
req.params.all() returns TRUE #2524
Comments
I'm running node |
I have upgraded to node 0.11.14 and req.params.all() still returns true! This is my
What are we doing wrong? Please help!!! |
Are you still having issues after v0.11? |
had this problem just yesterday. when changed to req.allParams() it works as intended. I'm using 0.11.0 |
problem appears to be on the params.all.js. Disabling the if alleviates the problem. |
Hello guys, I'm currently having the same issue with node 5.0.0 and sails 0.11.2. Best, |
Same here, using node 4.2.4 and sails 0.11.3, switching to |
I just encountered this very same issue. Using sails 0.12.7 and node 4.3.0. It happens on my feature branch but not on master, so I'm gonna try to find the culprit! |
Okay, I've debugged for hours and finally found the issue. So I went into the params.all.js file and logged the value of // console.log(req.params.all)
function () {
return this.every(Boolean);
} Very interesting. I decided to do a In the shim-array.js file I found the culprit. They actually define properties, |
The "collections" package has issues with array shims causing other dependencies to break when least expected. This has been discussed in multiple issues: - montagejs/collections#162 - montagejs/collections#95 - balderdashy/sails#2524 Another solution to this could be to depend on "collections@2.0.2" instead which is a version without shims.
Hi.
We are having issues with sails when parsing req values in blueprints actions.
req.params.all() instead of returning the same as req.allParams() it returns TRUE.
Why could this be happening? They are suppossed to be synonyms right?
req.allParams() works fine and returns an object with all request params.
Node 0.10.33
Sails 0.10.5
Any help is appreciated.
The text was updated successfully, but these errors were encountered: