[patch] Fix incorrect handling of Error objects in handleError() and add test… #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to prevent regression of same. With this change the error response created by the default response hooks will include more information when an error is encountered while processing a request. The body of the HTTP response will include a message and stack (if not in production.)
|
Thanks for posting, @tapuzzo-fsi! We'll look into this ASAP. |
|
@tapuzzo-fsi awesome, thank you! |
mikermcneil
added a commit
that referenced
this pull request
Mar 9, 2016
[patch] Fix incorrect handling of Error objects in handleError() and add test…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect handling of Error objects in handleError() and add test to prevent regression of same. With this change the error response created by the default response hooks will include more information when an error is encountered while processing a request. The body of the HTTP response will include a message and stack (if not in production.)