use symfony process to run shell command

Css/PreProcessor/Adapter/Less/Processor.php

@@ -16,6 +16,7 @@
 use Magento\Framework\View\Asset\File as AssetFile;
 use Magento\Framework\View\Asset\Source;
 use Psr\Log\LoggerInterface;
+use Symfony\Component\Process\Process;
 
 class Processor implements ContentProcessorInterface
 {
@@ -93,29 +94,37 @@ public function processContent(AssetFile $asset)
      */
     protected function compileFile($filePath)
     {
-        $nodeCmdArgs = $this->getNodeArgsAsArray();
-        $lessCmdArgs = $this->getCompilerArgsAsArray();
-
-        $cmd = '%s ' . str_repeat(' %s', count($nodeCmdArgs)) . ' %s' . str_repeat(' %s', count($lessCmdArgs)) . ' %s';
-        $arguments = [];
-        $arguments[] = $this->getPathToNodeBinary();
-        $arguments = array_merge($arguments, $nodeCmdArgs);
-        $arguments[] = $this->getPathToLessCompiler();
-        $arguments = array_merge($arguments, $lessCmdArgs);
-        $arguments[] = $filePath;
-
-        // to log or not to log, that's the question
-        // also, it would be better to use the logger in the Shell class,
-        // since that one will contain the exact correct command, and not this sprintf version
-        // $logArguments = array_map('escapeshellarg', $arguments);
-        // $this->logger->debug('Less compilation command: `'
-        //     . sprintf($cmd, ...$logArguments)
-        //     . '`');
-
-        return $this->shell->execute(
-            $cmd,
-            $arguments
-        );
+        $process = new Process([
+            $this->getPathToNodeBinary(),
+            ...$this->getNodeArgsAsArray(),
+            $this->getPathToLessCompiler(),
+            ...$this->getCompilerArgsAsArray(),
+            $filePath,
+        ]);
+
+        $process->run();
+
+        if (!$process->isSuccessful()) {
+            $error = sprintf(
+                'The command "%s" failed.'."\n\nExit Code: %s(%s)\n\nWorking directory: %s",
+                $process->getCommandLine(),
+                $process->getExitCode(),
+                $process->getExitCodeText(),
+                $process->getWorkingDirectory()
+            );
+
+            if (!$process->isOutputDisabled()) {
+                $error .= sprintf(
+                    "\n\nOutput:\n================\n%s\n\nError Output:\n================\n%s",
+                    $process->getOutput(),
+                    $process->getErrorOutput()
+                );
+            }
+
+            throw new LocalizedException(__($error));
+        }
+
+        return $process->getOutput();
     }
 
     /**

composer.json

@@ -19,7 +19,8 @@
     "require": {
         "php": "~5.5.0 || ~5.6.0 || ~7.0.0 || ~7.1.0 || ~7.2.0 || ~7.3.0 || ~7.4.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
         "magento/framework": "^100.0.9 || ^101.0.0 || ^102.0.0 || ^103.0.0",
-        "magento/module-developer": "^100.0.5"
+        "magento/module-developer": "^100.0.5",
+        "symfony/process": "^4.4|^5.0|^6.0"
     },
     "require-dev": {
         "bamarni/composer-bin-plugin": "^1.8",