Join GitHub today
Fix path separator used by normalizeTarEntry() under Windows #8
I've just force-pushed a complete replacement of the previous code, because I when I actually tested it on Windows, it failed. @zvin and others, apologies for having placed the original PR for review before having tested it on Windows (luckily it was a very small change...). What is now up for review has been tested on Windows and MacOS. Thanks!
OK, one more change. The tests were passing on Windows and MacOS, yes, but then I thought of additional test cases which were failing on all platforms:
(At least some of those were failing.) Also I have added removal of any trailing slashes. The purpose of normalization is to provide a single representation for multiple ways of referring to the same entity, so for example directories
I think the trailing slash removal, however, could be seen as a breaking change (?), and for this reason I have set the change-type to 'major'.