Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node 18.16.0 tests #1706

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix node 18.16.0 tests #1706

merged 1 commit into from
Apr 20, 2023

Conversation

JSReds
Copy link
Contributor

@JSReds JSReds commented Apr 20, 2023

issue due to nodejs/node#47563

Change-type: patch

Connects-to: #
See:
Depends-on:
Change-type: major|minor|patch


Contributor checklist
  • I have regenerated jest snapshots for any affected components with npm run generate-snapshots
Reviewer Guidelines
  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

issue due to nodejs/node#47563

Change-type: patch
@JSReds
Copy link
Contributor Author

JSReds commented Apr 20, 2023

lgtm!

@JSReds JSReds merged commit a8e5aeb into master Apr 20, 2023
@JSReds JSReds deleted the fix-tests-node-18-16 branch April 20, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant