Device: Fix the last_seen field not showing up

Change-type: patch Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
balena-io · Jul 9, 2020 · 7260a1a · 7260a1a
1 parent d8795ec
commit 7260a1a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/lib/actions-oclif/device/index.ts b/lib/actions-oclif/device/index.ts
@@ -28,6 +28,7 @@ interface ExtendedDevice extends Device {
 	dashboard_url?: string;
 	application_name?: string;
 	commit?: string;
+	last_seen?: string;
 }
 
 interface FlagsDef {
@@ -98,6 +99,7 @@ export default class DeviceCmd extends Command {
 			: 'N/a';
 
 		device.commit = device.is_on__commit;
+		device.last_seen = device.last_connectivity_event;
 
 		console.log(
 			getVisuals().table.vertical(device, [

diff --git a/tests/commands/device/device.spec.ts b/tests/commands/device/device.spec.ts
@@ -90,7 +90,7 @@ describe('balena device', function () {
 
 		const lines = cleanOutput(out);
 
-		expect(lines).to.have.lengthOf(13);
+		expect(lines).to.have.lengthOf(14);
 		expect(lines[0]).to.equal('== SPARKLING WOOD');
 		expect(lines[6].split(':')[1].trim()).to.equal('test app');
 
@@ -118,7 +118,7 @@ describe('balena device', function () {
 
 		const lines = cleanOutput(out);
 
-		expect(lines).to.have.lengthOf(13);
+		expect(lines).to.have.lengthOf(14);
 		expect(lines[0]).to.equal('== SPARKLING WOOD');
 		expect(lines[6].split(':')[1].trim()).to.equal('N/a');
 

diff --git a/tests/test-data/api-response/device-missing-app.json b/tests/test-data/api-response/device-missing-app.json
@@ -11,6 +11,7 @@
 	  "is_on__commit": "18756d3386c25a044db66b89e0409804",
 	  "note": null,
 	  "is_online": false,
+	  "last_connectivity_event": "2019-11-23T00:26:35.074Z",
 	  "ip_address": "192.168.0.112",
 	  "mac_address": null,
 	  "os_version": "balenaOS 2.44.0+rev3",

diff --git a/tests/test-data/api-response/device.json b/tests/test-data/api-response/device.json
@@ -15,6 +15,7 @@
 	  "is_on__commit": "18756d3386c25a044db66b89e0409804",
 	  "note": null,
 	  "is_online": false,
+	  "last_connectivity_event": "2019-11-23T00:26:35.074Z",
 	  "ip_address": "192.168.0.112",
 	  "mac_address": null,
 	  "os_version": "balenaOS 2.44.0+rev3",