Device: explicitly fetch only the presented fields #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
changed the title
pdcastro
previously approved these changes
Jul 9, 2020
thgreasi
added
the
versionbot/pr-draft
ghost
dismissed
pdcastro鈥檚 stale review
Approval reviews not allowed in Draft PRs
thgreasi
removed
the
versionbot/pr-draft
thgreasi
force-pushed
the
explicitly-select-device-fields
branch
2 times, most recently
from
e7094e2
to
d58dc74
Compare
pdcastro
approved these changes
Jul 9, 2020
|
@balena-ci rebase |
balena-ci
force-pushed
the
explicitly-select-device-fields
branch
from
d58dc74
to
7260a1a
Compare
|
@balena-ci rebase |
Depends on open-balena adding the mac_address & the overall_status device fields, but the latest cli version is probably already not working, since some of its dependencies already use the v14 SDK which needs the v6 model, that the open-balena-api doesn't have yet either. Change-type: minor See: https://www.flowdock.com/app/rulemotion/i-cli/threads/SaSXFlJEv-dpk9uUngWY225zv2D See: balena-io/open-balena-api#388 See: balena-io/open-balena-api#338 See: balena-io/balena-sdk#920 Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
Change-type: patch Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
balena-ci
force-pushed
the
explicitly-select-device-fields
branch
from
7260a1a
to
477c48f
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on open-balena adding the mac_address &
the overall_status device fields, but the latest cli
version is probably already not working, since some
of its dependencies already use the v14 SDK which
needs the v6 model, that the open-balena-api doesn't
have yet either.
This also revealed (SDK pine client typings 馃榿) that at some point we forgot to migrate the
last_seenfield, so before this it didn't show up.Change-type: minor
See: https://www.flowdock.com/app/rulemotion/i-cli/threads/SaSXFlJEv-dpk9uUngWY225zv2D
See: balena-io/open-balena-api#388
See: balena-io/open-balena-api#338
See: balena-io/balena-sdk#920
Signed-off-by: Thodoris Greasidis thodoris@balena.io
Please check the CONTRIBUTING.md file for relevant information and some
guidance. Keep in mind that the CLI is a cross-platform application that runs
on Windows, macOS and Linux. Tests will be automatically run by balena CI on
all three operating systems, but this will only help if you have added test
code that exercises the modified or added feature code.
Note that each commit message (currently only the first line) will be
automatically copied to the CHANGELOG.md file, so try writing it in a way
that describes the feature or fix for CLI users.
If there isn't a linked issue or if the linked issue doesn't quite match the
PR, please add a PR description to explain its purpose or the features that it
implements. Adding PR comments to blocks of code that aren't self explanatory
usually helps with the review process.
If the PR introduces security considerations or affects the development, build
or release process, please be sure to highlight this in the PR description.
Thank you very much for your contribution!