Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating an application with a discontinued device type should fail #358

Closed
pimterry opened this issue Jul 31, 2017 · 6 comments
Closed

Creating an application with a discontinued device type should fail #358

pimterry opened this issue Jul 31, 2017 · 6 comments

Comments

@pimterry
Copy link
Contributor

pimterry commented Jul 31, 2017 •
edited by thgreasi

HQ: resin-io/hq#785
See: resin-io/resin-ui#998
@thgreasi
Copy link
Member

As far as I could find in the already deprecated repos, the condition seems to be state == 'discontinued'.

@pimterry pimterry changed the title Creating an application with a deprecated device type should fail Creating an application with a discontinued device type should fail Jul 31, 2017
@pimterry
Copy link
Contributor Author

@thgreasi good point, updated.

@thgreasi
Copy link
Member

thgreasi commented Aug 1, 2017 •
edited

@pimterry I also think that we currently do not filter at all the supported device types.
The interested question is whether we should also filter out both the DEPRECATED (the UI already does this manually) and the discontinued states. (Loved the inconsistent casing!)

@pimterry
Copy link
Contributor Author

pimterry commented Aug 1, 2017

I think we still don't want to do any filtering there, even after this change. The UI and other places still need to know about these discontinued device types, so they can handle existing applications using it, it's only in application creation behaviour that anything major will change (plus potential UI changes in how we display these device types).

@thgreasi
Copy link
Member

thgreasi commented Aug 1, 2017

OK!

@pimterry pimterry mentioned this issue Sep 21, 2017
Merged
pimterry added a commit that referenced this issue Sep 21, 2017
@pimterry
*BREAKING*: Don't allow creating devices with discontinued device types
6878ae7 
Connects-To: #358
Change-Type: major
pimterry added a commit that referenced this issue Sep 22, 2017
@pimterry
*BREAKING*: Don't allow creating devices with discontinued device types
a0b03f3 
Connects-To: #358
Change-Type: major
pimterry added a commit that referenced this issue Sep 22, 2017
@pimterry
*BREAKING*: Don't allow creating applications with discontinued devic…
b726362 
…e types

Connects-To: #358
Change-Type: major
pimterry added a commit that referenced this issue Sep 22, 2017
@pimterry
*BREAKING*: Don't allow creating applications with discontinued devic…
2604056 
…e types

Connects-To: #358
Change-Type: major
@pimterry pimterry mentioned this issue Sep 22, 2017
Merged
pimterry added a commit that referenced this issue Sep 22, 2017
@pimterry
*BREAKING*: Don't allow creating applications with discontinued devic…
174ea0c 
…e types

Connects-To: #358
Change-Type: major
pimterry added a commit that referenced this issue Sep 26, 2017
@pimterry
*BREAKING*: Don't allow creating applications with discontinued devic…
015fe0e 
…e types

Connects-To: #358
Change-Type: major
pimterry added a commit that referenced this issue Sep 28, 2017
@pimterry
*BREAKING*: Don't allow creating applications with discontinued devic…
645bd3c 
…e types

Connects-To: #358
Change-Type: major
pimterry added a commit that referenced this issue Sep 28, 2017
@pimterry
*BREAKING*: Don't allow creating applications with discontinued devic…
fbe9d0f 
…e types

Connects-To: #358
Change-Type: major
pimterry added a commit that referenced this issue Sep 29, 2017
@pimterry
*BREAKING*: Don't allow creating applications with discontinued devic…
0ba42c7 
…e types

Connects-To: #358
Change-Type: major
pimterry added a commit that referenced this issue Oct 11, 2017
@pimterry
*BREAKING*: Don't allow creating applications with discontinued devic…
8a2b374 
…e types

Connects-To: #358
Change-Type: major
pimterry added a commit that referenced this issue Oct 12, 2017
@pimterry
*BREAKING*: Don't allow creating applications with discontinued devic…
4391099 
…e types

Connects-To: #358
Change-Type: major
@pimterry pimterry mentioned this issue Oct 12, 2017
Merged
@pimterry
Copy link
Contributor Author

Fixed in 7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thgreasi @pimterry