Breaking: Don't allow creating devices with discontinued device types #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
reviewed
Sep 22, 2017
| .then ([ deviceSlug, parentApplication ]) -> | ||
| return Promise.all([ deviceManifestPromise, parentAppPromise ]) | ||
| .then ([ deviceManifest, parentApplication ]) -> | ||
| if deviceManifest.state == 'DISCONTINUED' |
There was a problem hiding this comment.
How about adding
throw new errors.ResinInvalidDeviceType(deviceType) if !deviceManifest?
There was a problem hiding this comment.
I think we discussed this at summit, and it is already covered by the .tap check above.
There was a problem hiding this comment.
Opps, forgot to approve right after!
…e types Connects-To: #358 Change-Type: major
pimterry
force-pushed
the
358-discontinued-device-types
branch
from
2604056
to
174ea0c
Compare
thgreasi
approved these changes
Sep 25, 2017
pimterry
added a commit
that referenced
this pull request
Sep 26, 2017
Breaking: Don't allow creating devices with discontinued device types
pimterry
added a commit
that referenced
this pull request
Sep 28, 2017
Breaking: Don't allow creating devices with discontinued device types
pimterry
added a commit
that referenced
this pull request
Sep 29, 2017
Breaking: Don't allow creating devices with discontinued device types
pimterry
added a commit
that referenced
this pull request
Oct 11, 2017
Breaking: Don't allow creating devices with discontinued device types
pimterry
added a commit
that referenced
this pull request
Oct 12, 2017
Breaking: Don't allow creating devices with discontinued device types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes this issue from a month or so ago: #358.
This is a breaking change (because users currently might be automatically creating
edgedevices, and that will now fail). To handle that, we're not going to merge this into master or use versionbot: we're going to merge quietly into a v7 branch for now, along with other upcoming breaking changes (API v3 & API keys), and then merge these all together with versionbot to master, to do a single breaking v7 release with all 3 included.Connects-To: #358
Change-Type: major (!!!)
HQ: resin-io/hq#785
See: resin-io/resin-ui#998
---- Autogenerated Waffleboard Connection: Connects to #358