Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Runtime Info #307

Merged
merged 6 commits into from
Sep 1, 2016
Merged

Container Runtime Info #307

merged 6 commits into from
Sep 1, 2016

Conversation

shaunmulligan
Copy link
Contributor

@imrehg @craig-mulligan and @pcarranzav would love some review on this PR, added quiet a bit of stuff on resin container runtime and not sure if its 100% accurate or clear :P

---
# Container Runtime

On resin.io devices all your application code runs a [ Docker container][container-link]. This means that whatever you define as `CMD` in your `Dockerfile` will be PID 1 of the process tree in your container. It also means that this PID 1 process needs to know how to properly process UNIX signals, reap orphan zombie processes [[1]][ref-one] and if it crashes your whole container crashes, losing logs and debug info.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the ref-one be an inline reference? I don't have a problem with [1] in general, though we don't normally use this citation style in general, so it stands out. (not problem, just comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, thats a fair point, I'll make it inline

@craigmulligan
Copy link
Contributor

LGTM, in some cases I feel like you could add more confidence to the language. Eg. Replacing should with will. Great to have environment documented and all the tips + tricks. 👍

@shaunmulligan
Copy link
Contributor Author

@craig-mulligan and @imrehg addressed most of the comments and responded where appropriate. Lets get this guy out there

@imrehg
Copy link
Contributor

imrehg commented Aug 31, 2016

@shaunmulligan thanks for the updates, look awesome, and comments make sense! :)

And sorry, I had to push out a change in the meantime for Bryan, which conflicts with this one in config/navigation.txt, I guess a rebase on master would do the trick to resolve?

@emirotin
Copy link
Contributor

Rebase and resolve is the way to go indeed.


If you want specific data or configurations to persist on the device through the update process, you will need to store them in `/data` . This is a special folder on the device file system which is essentially a [docker data `VOLUME`][docker-volume-link].
<!-- TODO: explain how to reboot from systemd -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to reboot from systemd:

DBUS_SYSTEM_BUS_ADDRESS=unix:path=/host_run/dbus/system_bus_socket dbus-send --system --print-reply --dest=org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager.Reboot

@shaunmulligan
Copy link
Contributor Author

rebased and resolved. merging....

@shaunmulligan shaunmulligan merged commit d64f642 into master Sep 1, 2016
@sradevski sradevski deleted the runtime branch March 13, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants