New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Lodash templates #1810
Comments
Would this change have any knock-on effects if/when we decide to localize Etcher? ( #308 ) |
Can't see how, I don't believe Edit: Ah, I see what you mean now. Because they're pure strings it would be possible to keep them in separate files and also without worrying about injection of other variables, assuming that could be dangerous. |
Fair enough :) I just wondered if searching for |
In terms of localization, string templates could be easily fitted with it by sticking a tag function in front of it (see tagged template literals), far easier than mending lodash templates. |
I would like to work on this. |
style: fixed linter errors style: fixed linter errors refactor: remove enclosing array brackets. remove enclosing array brackets for single string. refactor: replace lodash templates balena-io#1810
We replace the lodash templates with arrow-functions and change the single-argument object into multiple arguments. Change-Type: patch Changelog-Entry: Replace Lodash templates with arrow-functions.
We replace the lodash templates with arrow-functions and change the single-argument object into multiple arguments. Change-Type: patch Changelog-Entry: Replace Lodash templates with arrow-functions.
Instead we could simply use lambdas and native template literals, e.g.
The text was updated successfully, but these errors were encountered: