Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No drives detected on packaged Windows #28

Closed
jviotti opened this issue Nov 18, 2015 · 4 comments
Closed

No drives detected on packaged Windows #28

jviotti opened this issue Nov 18, 2015 · 4 comments
Assignees
@jviotti
Labels
platform:windows

Comments

@jviotti
Copy link
Contributor

jviotti commented Nov 18, 2015

No description provided.

@jviotti
Copy link
Contributor Author

jviotti commented Nov 18, 2015

Drives are detected when packaging from Windows.

@jviotti jviotti mentioned this issue Nov 18, 2015
Closed
@jviotti jviotti assigned jviotti and unassigned jviotti Nov 18, 2015
@jviotti
Copy link
Contributor Author

jviotti commented Nov 30, 2015

This was almost fixed by the following PR: electron/electron#3595 where we fix electron's execFile file system override to execute scripts inside asar packages, however we're still blocked by the fact that we cannot pass the full path to a *.bat script to execFile (we need to set cwd, which electron will not handle correctly under an asar package).

@jviotti
Copy link
Contributor Author

jviotti commented Dec 1, 2015

Turns out the issue is that the extension of the script is not preserved when extracting out of an asar (a generic .tmp is added instead), which causes Windows to not know what to do or how to execute this .tmp file.

I'll send a PR to electron soon.

@jviotti
Copy link
Contributor Author

jviotti commented Dec 14, 2015

This was fixed in v0.36.0.

@jviotti jviotti closed this as completed Dec 14, 2015
balena-ci pushed a commit that referenced this issue Mar 21, 2019
@szb512
Merge pull request #28 from szb512/dependabot/npm_and_yarn/@babel/pre…
8d960ab 
…set-env-7.3.4

Bump @babel/preset-env from 7.3.1 to 7.3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jviotti jviotti

Labels
platform:windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jviotti