-
Notifications
You must be signed in to change notification settings - Fork 63
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use babel-minify to optimize the supervisor code
We've been using UglifyJS (the webpack default) so far, but this doesn't support ES6 and some dependency updates are starting to cause builds to break (e.g. request/request#2772, which also happens to break my builds in the multicontainer branch). Here we switch to using babel-minify which is designed for ES2015 support. I had to disable the "mangle" option because some dependencies break when mangled by babel-minify (which is a bit mysterious since it should be able to handle them well, but there's at least one case where an eval() in a dependency breaks the supervisor). This adds ~800kB to the resulting uncompressed image. Since the optimization now happens with a plugin instead of the webpack command line, we can't do the no-optimize trick we were doing in dindctl now - but it should also be less important now that we don't mangle names. Change-Type: patch Signed-off-by: Pablo Carranza Velez <pablo@resin.io>
- Loading branch information
Pablo Carranza Velez
committed
Nov 9, 2017
1 parent
62cf72b
commit e734c14
Showing
3 changed files
with
12 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters