Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default rp_filter to 2 #1555

Merged
merged 4 commits into from
Jun 13, 2019
Merged

Default rp_filter to 2 #1555

merged 4 commits into from
Jun 13, 2019

Conversation

agherzan
Copy link
Contributor

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@agherzan agherzan requested a review from ZubairLK June 12, 2019 17:04
systemd/pyro: Backport patch to switch all.rp_filter from 1 to 2
2fe90f3 
This change backports a PR[1] that is already in systemd and will come
included by default from the version in Yocto warrior.

In summary, with this change we fix newer NM which stopped handling
rp_filter when connected to multiple interfaces. See "device: disable
rp_filter handling" commit from NM. Without this change, only the
default route will me usable and binding to a specific interface will
break connectivity if that interface is not also the default route for
the target IP.

[1]systemd/systemd@6caa14f

Change-type: minor
Changelog-entry: Use all.rp_filter=2 as the default value in balenaOS
Signed-off-by: Andrei Gherzan <andrei@balena.io>
@agherzan
Copy link
Contributor Author

Repush notes: fixed patch on pyro

Andrei Gherzan added 3 commits June 13, 2019 14:00
systemd/rocko: Backport patch to switch all.rp_filter from 1 to 2
59cd4c0 
This change backports a PR[1] that is already in systemd and will come
included by default from the version in Yocto warrior.

In summary, with this change we fix newer NM which stopped handling
rp_filter when connected to multiple interfaces. See "device: disable
rp_filter handling" commit from NM. Without this change, only the
default route will me usable and binding to a specific interface will
break connectivity if that interface is not also the default route for
the target IP.

[1]systemd/systemd@6caa14f

Signed-off-by: Andrei Gherzan <andrei@balena.io>
systemd/sumo Backport patch to switch all.rp_filter from 1 to 2
214ce6c 
This change backports a PR[1] that is already in systemd and will come
included by default from the version in Yocto warrior.

In summary, with this change we fix newer NM which stopped handling
rp_filter when connected to multiple interfaces. See "device: disable
rp_filter handling" commit from NM. Without this change, only the
default route will me usable and binding to a specific interface will
break connectivity if that interface is not also the default route for
the target IP.

[1]systemd/systemd@6caa14f

Signed-off-by: Andrei Gherzan <andrei@balena.io>
systemd/thud: Backport patch to switch all.rp_filter from 1 to 2
c042f4c 
This change backports a PR[1] that is already in systemd and will come
included by default from the version in Yocto warrior.

In summary, with this change we fix newer NM which stopped handling
rp_filter when connected to multiple interfaces. See "device: disable
rp_filter handling" commit from NM. Without this change, only the
default route will me usable and binding to a specific interface will
break connectivity if that interface is not also the default route for
the target IP.

[1]systemd/systemd@6caa14f

Signed-off-by: Andrei Gherzan <andrei@balena.io>
@agherzan
Copy link
Contributor Author

Repush notes: fixed patch on rocko.

@agherzan
Copy link
Contributor Author

@balena-ci retest

@agherzan agherzan merged commit f21a2a3 into development Jun 13, 2019
@agherzan agherzan deleted the ag/rp_filter branch June 13, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZubairLK ZubairLK ZubairLK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agherzan @ZubairLK