Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename resin to balena where possible #1741

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Rename resin to balena where possible #1741

merged 1 commit into from
Nov 13, 2019

Conversation

Page-
Copy link
Contributor

@Page- Page- commented Nov 12, 2019

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@Page- Page- requested a review from ZubairLK as a code owner November 12, 2019 15:58
@resin-jenkins
Copy link

Can one of the admins verify this patch?

@floion
Copy link
Collaborator

floion commented Nov 12, 2019

@resin-jenkins add to whitelist

@@ -1,7 +1,7 @@
# Resin.io layer for Poky Thud supported boards
# Balena.io layer for Poky Thud supported boards
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be lowercase? Same thing in other places in this PR too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do use an initial cap for the start of a sentence, but as a general rule I replaced with matching case

@Page- Page- requested a review from floion November 12, 2019 21:43
@Page- Page- merged commit 73d474c into development Nov 13, 2019
@Page- Page- deleted the rename branch November 13, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants