Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filter card feature #8052

Closed
keizer619 opened this issue Oct 17, 2023 · 8 comments · Fixed by #8103
Closed

Implement filter card feature #8052

keizer619 opened this issue Oct 17, 2023 · 8 comments · Fixed by #8103
Assignees
Labels
Hacktoberfest Type/Improvement Improvements required on the website.

Comments

@keizer619
Copy link
Member

Description

Currently there are tabs displayed in following pages. Those tags should be clickable to filter and remove filter

https://ballerina.io/learn/integration-tutorials/
https://ballerina.io/learn/pre-built-integrations/
https://ballerina.io/learn/enterprise-integration-patterns/

Screenshot 2023-10-17 at 23 04 59
@keizer619 keizer619 added Type/NewFeature New features required on the website. Type/Improvement Improvements required on the website. Hacktoberfest and removed Type/NewFeature New features required on the website. labels Oct 17, 2023
@LG-blip
Copy link

LG-blip commented Oct 18, 2023

I would like to work on this project

@sm1990
Copy link
Contributor

sm1990 commented Oct 18, 2023

Hi @LG-blip

First of all, thank you for choosing to contribute to Ballerina website.

This issue is related to the rendering of code snippets through out our website and you can work on this issue.

Please note that this issue is eligible for both Ballerina Hacktoberfest and Digital Ocean Hacktoberfest.

Let me know if you need anything else.

Happy coding!!!!! 😄

@LG-blip
Copy link

LG-blip commented Oct 18, 2023

Those tags should be clickable to "filter and remove filter" ? i couldn't understand this part could you explain?

@sm1990
Copy link
Contributor

sm1990 commented Oct 18, 2023

Those tags should be clickable to "filter and remove filter" ? i couldn't understand this part could you explain?

Yes. Currently they're just some text inside a span. Make the whole span/badge clickable.
Once you click, It should filter the items and show the current filter above the cards as below.
image

The new badge should have a close button (denoted by the X in the image) to remove the filter.

Let me know if there are anymore questions.

@Pinaka-Pani-18
Copy link
Contributor

Hi @sm1990 ,

I've worked on this issue, and now it works as follows.
https://github.com/ballerina-platform/ballerina-dev-website/assets/102857774/0263de75-32fb-4fc3-a9aa-b6acc1b3587d

If you're okay with it, I'll proceed with the remaining part and create a PR.

If you have any suggestions for improvements, please let me know.

@sm1990
Copy link
Contributor

sm1990 commented Oct 23, 2023

@LG-blip any update on this issue? If you are not working on this can you assign it to @Pinaka-Pani-18 as his solution seems to be correct.

@LG-blip
Copy link

LG-blip commented Oct 23, 2023

Okay

@sm1990 sm1990 assigned Pinaka-Pani-18 and unassigned LG-blip Oct 25, 2023
@sm1990
Copy link
Contributor

sm1990 commented Oct 25, 2023

@Pinaka-Pani-18 can you send the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Type/Improvement Improvements required on the website.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants