Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feature ] - Implemented the filter card #8103

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

Pinaka-Pani-18
Copy link
Contributor

Purpose

Now we can filter the cards by clicking on the tags.
Fixes #8052

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023

CLA assistant check
All committers have signed the CLA.

@sm1990
Copy link
Contributor

sm1990 commented Oct 25, 2023

In pre-built-integrations the once you add the 3rd filter, the second one gets replaced.
In enterprise-integration-patterns and Integration tutorials, the 2nd filter is not working.
Remove the package-lock.json from the PR, since you haven't installed any new packages.

@Pinaka-Pani-18
Copy link
Contributor Author

Pinaka-Pani-18 commented Oct 25, 2023

In pre-built-integrations the once you add the 3rd filter, the second one gets replaced. In enterprise-integration-patterns and Integration tutorials, the 2nd filter is not working. Remove the package-lock.json from the PR, since you haven't installed any new packages.

In the 'pre-built-integrations' section, there was a duplicate issue, which I will fix. However, in the 'enterprise-integration-patterns' and 'Integration tutorials' sections, it is working fine. If any of the selected tags is present, it will display the card as shown in the video.

00-57-49.mp4

@sm1990
Copy link
Contributor

sm1990 commented Oct 26, 2023

@Pinaka-Pani-18 please check the following videos.

EIP.mp4
IT.mp4
pre-built.mp4

@Pinaka-Pani-18
Copy link
Contributor Author

In the first two videos, it works like this: If any of the selected tags are present, it shows the card.
Are you expecting it to filter only when both tags are present on the card to display it?

In the third video, there are duplicates, so it seems to be working like that. I will fix it.

@sm1990
Copy link
Contributor

sm1990 commented Oct 27, 2023

In the first two videos, it works like this: If any of the selected tags are present, it shows the card. Are you expecting it to filter only when both tags are present on the card to display it?

Yes. When you add the 2nd filter, it should select cards that have both tags.

@Pinaka-Pani-18
Copy link
Contributor Author

Hi @sm1990, I have made the necessary changes. Could you please review it now?

@sm1990 sm1990 requested a review from manuranga October 30, 2023 04:08
@sm1990 sm1990 changed the title [ Featute ] - Implemented the filter card [ Feature ] - Implemented the filter card Oct 30, 2023
@sm1990 sm1990 merged commit 21e3646 into ballerina-platform:master Oct 30, 2023
1 check passed
@sm1990
Copy link
Contributor

sm1990 commented Oct 30, 2023

@Pinaka-Pani-18 Thank you very much for your contribution. We are currently hosting a Ballerina Hacktoberfest. Since this issue is eligible for our event, please visit https://ballerina.io/hacktoberfest/#rules & submit the form. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement filter card feature
3 participants