Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp sending emails from a service tutorial #8133

Merged
merged 13 commits into from
Nov 3, 2023
Merged

Revamp sending emails from a service tutorial #8133

merged 13 commits into from
Nov 3, 2023

Conversation

mindula
Copy link
Contributor

@mindula mindula commented Oct 30, 2023

Purpose

$title

Checklist

  • Page addition

    • Add permalink to pages.

  • Page removal

    • Remove entry from corresponding left nav YAML file.
    • Add redirect_from on the alternative page.
    • If no alternative page, add redirection on the redirections.js file.

  • Page rename

    • Add front-matter redirect_from.
    • Add front-matter redirect_to: (if applicable).

  • Page restrcuture

    • Add permalink to pages.
    • Add front-matter redirect_from.
    • Add front-matter redirect_to: (if applicable).

dulajdilshan
dulajdilshan reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@dulajdilshan dulajdilshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, It is nice to have a screenshot of the received email

@mindula mindula force-pushed the revamp-sending-emails-from-a-service branch from 47000b0 to 13d9aa2 Compare October 31, 2023 11:39
MaryamZi
MaryamZi reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@MaryamZi MaryamZi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note

  • there's a record named PaymentSettlement that's not used in the source
  • get rid of type inclusion and anonymous records and define new records for simplicity
  • remove destructuring, especially with rest binding patterns, also for simplicity

swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
@mindula mindula force-pushed the revamp-sending-emails-from-a-service branch from 13d9aa2 to 8053016 Compare November 1, 2023 09:35
@mindula mindula requested a review from MaryamZi November 1, 2023 09:42
MaryamZi
MaryamZi reviewed Nov 1, 2023
View reviewed changes
swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md Show resolved Hide resolved
swan-lake/integration-tutorials/sending-emails-from-a-service.md
@@ -612,85 +478,42 @@ function getEmailContent(int appointmentNumber, Appointment appointment, Payment

### Step 3: Build and run the service

You can run this service by navigating to the project root and using the `bal run` command.
![Run the service](/learn/images/integration-tutorials/sending-emails-from-a-service/run_the_service.gif)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for others let's follow /Users/username/integration-tutorials/tutorial-name as the root.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

swan-lake/integration-tutorials/sending-emails-from-a-service.md Outdated Show resolved Hide resolved
dulajdilshan
dulajdilshan reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@dulajdilshan dulajdilshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The complete source code needs to be updated.

@mindula mindula requested a review from MaryamZi November 2, 2023 06:24
@MaryamZi
Copy link
Member

MaryamZi commented Nov 2, 2023

The code looks OK to me now. Let's update the gifs and content.

@mindula mindula force-pushed the revamp-sending-emails-from-a-service branch from e73a83a to 259354f Compare November 2, 2023 09:00
@mindula mindula requested a review from MaryamZi November 2, 2023 15:55
@dulajdilshan dulajdilshan changed the title [Draft] Revamp sending emails from a service tutorial Revamp sending emails from a service tutorial Nov 3, 2023
@MaryamZi MaryamZi merged commit e3b64e8 into ballerina-platform:integration-tutorials Nov 3, 2023
1 check passed
dulajdilshan
dulajdilshan reviewed Nov 10, 2023
View reviewed changes
swan-lake/integration-tutorials/sending-emails-from-a-service.md
- Use `/healthcare` as the service path (or the context) for the service attached to the listener that is listening on port `port`.

- The HTTP resource allows the `POST` operation on resource path `/categories/{category}/reserve`, where `category` (corresponding to the specialization) is a path parameter.
> **Note:** Enable two factor authentication on your Google account, generate an app password, and use the app password in place of your email password. The app password can be generated with [this link](https://myaccount.google.com/apppasswords?pli=1&rapt=AEjHL4Mf5XDD4rE79YJpP5E2NoNwhvXMET_TWyBcQRn-HMzt0PI8BmptpMGRiBVIamW-0ECgVZtXxMRA19bL4Wfnq_hmjBEMqA).
Copy link
Contributor

@dulajdilshan dulajdilshan Nov 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attaching https://ballerina.io/learn/by-example/#configurability link is fine but, IMO, better to exaplain having a Config.toml within the tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulajdilshan dulajdilshan dulajdilshan left review comments

@MaryamZi MaryamZi MaryamZi approved these changes

@praneesha praneesha Awaiting requested review from praneesha

@sm1990 sm1990 Awaiting requested review from sm1990 sm1990 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mindula @MaryamZi @dulajdilshan