-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
previous and next buttons added on learn pages #8136
Conversation
@sm1990 I have added button. Can you please check if they are working? And if I am going in the right direction? |
@s-vamshi seems like you are on the right track. I noticed that the links don't work in |
@sm1990 will this pr get counted towards Hacktoberfest swags if it gets merged tomorrow? |
Yes. This will be still considered. 😄 |
@sm1990 great! If we are in first page, should we show the previous button which links to the last page and vice versa? |
@sm1990 id: cli-commands is same for two objects in learn-lm.json thats the reason in build run section cli command is linking wrongly |
The first page, should not have a previous button. |
@sm1990 can you please review once? |
The whole ballerina-dev-website/utils/learn-lm.json Line 1260 in c877086
|
@s-vamshi increase the space between the buttons and the text. |
@sm1990 should I remove references from learn lm .json |
yes |
@s-vamshi can you make the links turn to dark grey (refer the |
@sm1990 sure will do that |
@sm1990 I didn't submit swags form for this PR as it has not been merged, in discord there is an announcement, should I submit with PR link even if not merged? |
@sm1990 Can you please review now once? |
c205675
to
d2b872a
Compare
@sm1990 Can you please review changes? |
Yes you can submit the pr link. We will keep a note 😄 |
@sm1990 Can you please review now? |
@s-vamshi all seems to be good. But I noticed something with the flow. Can we have those links opening in new tabs to maintain consistency? There are few more such links. you can find them in the |
Sure will do that |
@sm1990 can you please check now? |
1 similar comment
@sm1990 can you please check now? |
@s-vamshi Thank you very mush for your contribution. Hope you filled the form in https://ballerina.io/hacktoberfest/#rules. |
😃 |
This is how it looks.
![image](https://private-user-images.githubusercontent.com/62489114/279262767-5c0ac346-3cf4-400b-b5b9-14ebbe1a0d4d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NzE0MDQsIm5iZiI6MTcyMDU3MTEwNCwicGF0aCI6Ii82MjQ4OTExNC8yNzkyNjI3NjctNWMwYWMzNDYtM2NmNC00MDBiLWI1YjktMTRlYmJlMWEwZDRkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAwMjUwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQxMGVlYTBiMGIxMzg5M2I1MzY5OTcxZjcyOWI2MGFjZWU5YzI4MjI0M2Q0NzYzMmYyNjhjZWU1YzJhMjZiY2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qQXtsLt2V05f3fGJmZa9g8nea8Q94WN0K5GrhYWsHSY)
NOTE: This are not final changes. There are few changes to be made.
Checklist
Page addition
permalink
to pages.Page removal
redirect_from
on the alternative page.redirections.js
file.Page rename
redirect_from
.redirect_to:
(if applicable).Page restrcuture
permalink
to pages.redirect_from
.redirect_to:
(if applicable).