Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previous and next buttons added on learn pages #8136

Merged
merged 10 commits into from
Nov 6, 2023

Conversation

s-vamshi
Copy link
Contributor

@s-vamshi s-vamshi commented Oct 31, 2023

Fixes #4902

This is how it looks.
image

NOTE: This are not final changes. There are few changes to be made.

Checklist

  • Page addition

    • Add permalink to pages.
  • Page removal

    • Remove entry from corresponding left nav YAML file.
    • Add redirect_from on the alternative page.
    • If no alternative page, add redirection on the redirections.js file.
  • Page rename

    • Add front-matter redirect_from.
    • Add front-matter redirect_to: (if applicable).
  • Page restrcuture

    • Add permalink to pages.
    • Add front-matter redirect_from.
    • Add front-matter redirect_to: (if applicable).

@s-vamshi
Copy link
Contributor Author

@sm1990 I have added button. Can you please check if they are working? And if I am going in the right direction?
There few things which needs to be changed like styles, which I will do subsequently.

@sm1990
Copy link
Contributor

sm1990 commented Oct 31, 2023

@s-vamshi seems like you are on the right track. I noticed that the links don't work in Build and run section. Also for styling, you can refer https://ballerina.io/learn/by-example/hello-world-service/

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Oct 31, 2023

@sm1990 will this pr get counted towards Hacktoberfest swags if it gets merged tomorrow?

@sm1990
Copy link
Contributor

sm1990 commented Oct 31, 2023

@sm1990 will this pr get counted towards Hacktoberfest swags if it gets merged tomorrow?

Yes. This will be still considered. 😄

@s-vamshi
Copy link
Contributor Author

@sm1990 great! If we are in first page, should we show the previous button which links to the last page and vice versa?

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 1, 2023

@sm1990 id: cli-commands is same for two objects in learn-lm.json thats the reason in build run section cli command is linking wrongly

@sm1990
Copy link
Contributor

sm1990 commented Nov 1, 2023

@sm1990 great! If we are in first page, should we show the previous button which links to the last page and vice versa?

The first page, should not have a previous button.

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 1, 2023

@sm1990 can you please review once?

@sm1990
Copy link
Contributor

sm1990 commented Nov 1, 2023

cli-commands

The whole reference section seems to be a leftover from the last restructuring we did. You can remove the whole object.(

"dirName": "references",
)

@sm1990
Copy link
Contributor

sm1990 commented Nov 1, 2023

@s-vamshi increase the space between the buttons and the text.
image
image

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 1, 2023

@sm1990 should I remove references from learn lm .json

@sm1990
Copy link
Contributor

sm1990 commented Nov 1, 2023

@sm1990 should I remove references from learn lm .json

yes

@sm1990
Copy link
Contributor

sm1990 commented Nov 1, 2023

@s-vamshi can you make the links turn to dark grey (refer the Back to pre-built button in https://ballerina.io/learn/pre-built-integrations/google-sheets-to-salesforce-integration/) on hover. Also remove the underline.

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 1, 2023

@sm1990 sure will do that

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 1, 2023

@sm1990 I didn't submit swags form for this PR as it has not been merged, in discord there is an announcement, should I submit with PR link even if not merged?

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 1, 2023

@sm1990 Can you please review now once?

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 2, 2023

@sm1990 Can you please review changes?

@sm1990
Copy link
Contributor

sm1990 commented Nov 2, 2023

@sm1990 I didn't submit swags form for this PR as it has not been merged, in discord there is an announcement, should I submit with PR link even if not merged?

Yes you can submit the pr link. We will keep a note 😄

@sm1990
Copy link
Contributor

sm1990 commented Nov 2, 2023

Getting this error when I click on the next link.
image

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 3, 2023

@sm1990 Can you please review now?
in learn lm.json there are two objects with id coding-conventions so removed the object which is not been used

@sm1990
Copy link
Contributor

sm1990 commented Nov 3, 2023

@s-vamshi all seems to be good. But I noticed something with the flow.
In Get started with integration section we have couple of pages opening in new tabs (e.g. Pre-built integrations, Enterprise integration patterns, and Integration tutorials).

Can we have those links opening in new tabs to maintain consistency? There are few more such links. you can find them in the Learn landing page https://ballerina.io/learn/.

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 3, 2023

Sure will do that

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 3, 2023

@sm1990 can you please check now?

1 similar comment
@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 6, 2023

@sm1990 can you please check now?

@sm1990 sm1990 merged commit 64590f6 into ballerina-platform:master Nov 6, 2023
1 check passed
@sm1990
Copy link
Contributor

sm1990 commented Nov 6, 2023

@sm1990 can you please check now?

@s-vamshi Thank you very mush for your contribution. Hope you filled the form in https://ballerina.io/hacktoberfest/#rules.

@s-vamshi s-vamshi deleted the prevnext-buttons branch November 6, 2023 06:40
@s-vamshi s-vamshi restored the prevnext-buttons branch November 6, 2023 06:41
@s-vamshi
Copy link
Contributor Author

s-vamshi commented Nov 6, 2023

@sm1990 can you please check now?

@s-vamshi Thank you very mush for your contribution. Hope you filled the form in https://ballerina.io/hacktoberfest/#rules.

😃
Yes I have filled the form last week when PR was not merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Next/Previous option on Learn pages
2 participants