Revamp content-based-message-routing tutorial
#8223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dulajdilshan
changed the title
content-based-message-routing tutorial
|
The |
dulajdilshan
commented
Nov 10, 2023
mindula
reviewed
Nov 10, 2023
swan-lake/integration-tutorials/content-based-message-routing.md
Outdated
Show resolved
Hide resolved
mindula
reviewed
Nov 10, 2023
swan-lake/integration-tutorials/content-based-message-routing.md
Outdated
Show resolved
Hide resolved
swan-lake/integration-tutorials/content-based-message-routing.md
Outdated
Show resolved
Hide resolved
swan-lake/integration-tutorials/content-based-message-routing.md
Outdated
Show resolved
Hide resolved
mindula
reviewed
Nov 10, 2023
mindula
reviewed
Nov 10, 2023
swan-lake/integration-tutorials/content-based-message-routing.md
Outdated
Show resolved
Hide resolved
mindula
reviewed
Nov 10, 2023
swan-lake/integration-tutorials/content-based-message-routing.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mindula Rowel <61020198+mindula@users.noreply.github.com>
dulajdilshan
merged commit cf84223
into
ballerina-platform:integration-tutorials
1 check passed
MaryamZi
reviewed
Nov 13, 2023
| > final http:Client clemencyEP = new ("http://localhost:9090/clemency/categories"); | ||
| > final http:Client pinevalleyEP = new ("http://localhost:9090/pinevalley/categories"); | ||
| >``` | ||
| 4. Generate record types corresponding to the payloads from the hospital backend services by providing samples of the expected JSON payloads. |
There was a problem hiding this comment.
There's only one backend call.
So
- payloads -> payload
- services -> service
Comment on lines
+167
to
+168
|
|
||
| type ReservationRequest record { |
There was a problem hiding this comment.
Let's move this out and have a similar point for request payload.
| @@ -243,77 +257,13 @@ Follow the instructions given in this section to develop the service. | |||
|
|
|||
| - Define the `hospitalEP` variable. Later, the relevant client is assigned to this variable based on the `hospital_id` value. | |||
There was a problem hiding this comment.
- Define an
http:Clientvariable namedhospitalEP. Later, the relevant client is assigned to this variable based on thehospital_idvalue.
| } | ||
| } | ||
| ``` | ||
|
|
||
| - Make a `POST` request to the backend hospital service to make the reservation. The `category` value is used as a path parameter. |
There was a problem hiding this comment.
- Make a
POSTrequest to the relevant backend hospital service to make the reservation. Thecategoryvalue is used as a path parameter.
| ```ballerina | ||
| {patient, doctor, ...reservationRequest} | ||
| ``` | ||
|
|
||
| - Use the `is` check to check whether the response is a `ReservationResponse` and return it as is (i.e., reservation successful). |
There was a problem hiding this comment.
- Use the
ischeck to check whether the response is aReservationResponserecord, which would indicate a successful reservation. If the response is aReservationResponserecord, return the record from the resource method to send a201 Createdresponse with theReservationResponsevalue as the payload.
|
|
||
| return <http:InternalServerError> {body: resp.message()}; | ||
| ``` | ||
| - If the response is not a `ReservationResponse`, log the failure at `ERROR` level. Return a "NotFound" response if the response is an `http:ClientRequestError`, or an "InternalServerError" response if the response is an `http:ServerError`. |
There was a problem hiding this comment.
"NotFound" -> http:NotFound
Fix "InternalServerError" too.
|
|
||
| return <http:InternalServerError> {body: resp.message()}; | ||
| ``` | ||
| - If the response is not a `ReservationResponse`, log the failure at `ERROR` level. Return a "NotFound" response if the response is an `http:ClientRequestError`, or an "InternalServerError" response if the response is an `http:ServerError`. |
There was a problem hiding this comment.
If the response is not a ReservationResponse record (i.e., http:ClientError), which indicates that the request failed, log the failure at ERROR level.
| type ReservationRequest record { | ||
| Patient patient; | ||
| string doctor; | ||
| HospitalId hospital_id; |
There was a problem hiding this comment.
The record isn't generated with HospitalId as the type, right? Let's add a note to mention updating this.
| HospitalId hospital_id; | ||
| string hospital; | ||
| string appointment_date; | ||
| }; |
There was a problem hiding this comment.
Doesn't Patient get generated twice? Can add a note asking to remove one if it matches an already existing record too.
There was a problem hiding this comment.
This could even be a tooling improvement. If we can check if there's a record that's the same type and same name, we avoid adding a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title
Checklist
Page addition
permalinkto pages.Page removal
redirect_fromon the alternative page.redirections.jsfile.Page rename
redirect_from.redirect_to:(if applicable).Page restrcuture
permalinkto pages.redirect_from.redirect_to:(if applicable).