Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix help text #329

Merged
merged 8 commits into from
Dec 16, 2019
Merged

Fix help text #329

merged 8 commits into from
Dec 16, 2019

Conversation

MaryamZi
Copy link
Member

@MaryamZi MaryamZi commented Dec 16, 2019 •
edited
Loading

Purpose

$title.

Fixes #336
Fixes #334
Fixes #332
Fixes #328
Fixes #327
Fixes #326
Fixes #324
Fixes #323
Fixes #322

@MaryamZi MaryamZi requested review from keizer619, warunalakshitha and Kishanthan and removed request for keizer619 December 16, 2019 06:47
keizer619
keizer619 reviewed Dec 16, 2019
View reviewed changes
ballerina-command/src/main/resources/cli-help/ballerina-help.help
@@ -1,8 +0,0 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaryamZi
We need to keep this file as its referred by the default command. This is used to merge all the help commands together (jballerina + command)

https://github.com/ballerina-platform/ballerina-distribution/blob/release-stage/ballerina-command/src/main/java/org/ballerinalang/command/cmd/DefaultCommand.java#L51

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that, added it back with 7a88cb7.

@MaryamZi MaryamZi mentioned this pull request Dec 16, 2019
Closed
@Kishanthan Kishanthan merged commit 0d0bf11 into ballerina-platform:release-stage Dec 16, 2019
This was referenced Dec 16, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 16, 2019
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keizer619 keizer619 keizer619 left review comments

@Kishanthan Kishanthan Kishanthan approved these changes

@warunalakshitha warunalakshitha Awaiting requested review from warunalakshitha

@anupama-pathirage anupama-pathirage Awaiting requested review from anupama-pathirage

@pubudu91 pubudu91 Awaiting requested review from pubudu91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaryamZi @Kishanthan @keizer619