Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ATTEMPT_EXPOSE_NON_PUBLIC_SYMBOL validation for Objects, Unions and other types. #18342

Open
hasithaa opened this issue Aug 30, 2019 · 3 comments
Open

Fix ATTEMPT_EXPOSE_NON_PUBLIC_SYMBOL validation for Objects, Unions and other types. #18342

hasithaa opened this issue Aug 30, 2019 · 3 comments
Labels
Area/TypeChecker Type Checker related issues #Compiler Priority/High SwanLakeDump All issues planned for Swan Lake GA release Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement
Projects
Ballerina Compiler Bug triage

Comments

@hasithaa
Copy link
Contributor

Description:
See Referred pull.
https://github.com/ballerina-platform/ballerina-lang/pull/18341/files#diff-4025beda7fd769ab390b6d789e6cec16R1241

Steps to reproduce:

Affected Versions:

OS, DB, other environment details and versions:

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):
@hasithaa hasithaa added Type/Bug Priority/High Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. labels Aug 30, 2019
@hasithaa hasithaa added this to New Issues in Ballerina Compiler Team Tasks via automation Aug 30, 2019
@hasithaa hasithaa mentioned this issue Aug 30, 2019
Merged
14 tasks
@pubudu91 pubudu91 added this to the Ballerina 1.0.x milestone Oct 17, 2019
@pubudu91 pubudu91 added this to Needs triage in Ballerina Compiler Bug triage via automation Oct 17, 2019
@gimantha gimantha moved this from Needs triage to [Reviewed] Minor compatible in Ballerina Compiler Bug triage Nov 1, 2019
@grainier grainier removed this from BackLog in Sprint 2 - Compiler Front-End Nov 19, 2019
@grainier grainier moved this from [Reviewed] Minor compatible to Targeted for Sprints in Ballerina Compiler Bug triage Nov 19, 2019
@hasithaa hasithaa removed this from the Ballerina 1.2.0 milestone Mar 20, 2020
@hasithaa
Copy link
Contributor Author

Spec allows exposing non-public types. Hence we should reconsider this adding this as a warning.

@hasithaa hasithaa added Area/TypeChecker Type Checker related issues #Compiler SwanLakeDump All issues planned for Swan Lake GA release Type/Improvement and removed Type/Bug labels Aug 24, 2020
@MaryamZi MaryamZi mentioned this issue Jan 5, 2021
Merged
13 tasks
@gimantha gimantha mentioned this issue Mar 22, 2021
Closed
@MaryamZi
Copy link
Member

Related issues
#30324
#23049

@MaryamZi MaryamZi mentioned this issue Mar 3, 2022
Closed
@MaryamZi
Copy link
Member

Should we prioritize this issue given that users would have to make constructs public to get rid of the error right now?

In addition to the compiler changes, we will also have to consider aspects such as doc generation.

@dulajdilshan dulajdilshan mentioned this issue Jul 12, 2022
Closed
@gimantha gimantha added Deferred Tag tasks not addressed >1 year, moved to closed state, until addressed in the future. and removed Deferred Tag tasks not addressed >1 year, moved to closed state, until addressed in the future. labels Feb 28, 2023
@gimantha gimantha removed the Deferred Tag tasks not addressed >1 year, moved to closed state, until addressed in the future. label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area/TypeChecker Type Checker related issues #Compiler Priority/High SwanLakeDump All issues planned for Swan Lake GA release Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement
Projects
No open projects
Ballerina Compiler Bug triage
  
Sprint - Issue pool
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hasithaa @rdhananjaya @pubudu91 @MaryamZi @gimantha