Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L1] Type Checking Improvements #18341

Merged
merged 15 commits into from Aug 30, 2019
Merged

[L1] Type Checking Improvements #18341

merged 15 commits into from Aug 30, 2019

Conversation

hasithaa
Copy link
Contributor

@hasithaa hasithaa commented Aug 30, 2019 •
edited

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #16458
Fixes #18152
Fixes #18344

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Required Balo version update
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

hasithaa
hasithaa commented Aug 30, 2019
View reviewed changes
...rina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/CodeAnalyzer.java
this.checkStatementExecutionValidity(foreverStatement);
this.lastStatement = true;
}

public void visit(BLangObjectTypeNode objectTypeNode) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are moved to one place

hasithaa
hasithaa commented Aug 30, 2019
View reviewed changes
...rina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/CodeAnalyzer.java
checkForExportableType(streamType.constraint.tsymbol, pos);
}
return;
// TODO : Add support for other types. such as union and objects
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue to track this. : #18342

This was referenced Aug 30, 2019
Closed
Closed
@MaryamZi MaryamZi added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Aug 30, 2019
@hasithaa hasithaa added this to the Ballerina 1.0.0-beta milestone Aug 30, 2019
@hasithaa hasithaa changed the base branch from master to lang-1.0.0-beta August 30, 2019 11:51
@hasithaa hasithaa merged commit dc56417 into ballerina-platform:lang-1.0.0-beta Aug 30, 2019
@hasithaa hasithaa deleted the Fix_16458_typeparam branch September 17, 2019 17:21
@keizer619 keizer619 modified the milestones: Ballerina 1.0.0-beta, Ballerina 1.0.0 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryamZi MaryamZi MaryamZi approved these changes

@rdhananjaya rdhananjaya Awaiting requested review from rdhananjaya

@pubudu91 pubudu91 Awaiting requested review from pubudu91

Assignees
No one assigned
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Milestone
Ballerina 1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hasithaa @MaryamZi @keizer619