Renaming a symbol at the point of use doesn't work within service decls

[pubudu91]

For example,

listener http:Listener ep = new http:Listener(9090);

service / on ep {
    resource function get getResource(http:Caller caller, http:Request req) {
        
    }
}

Try renaming ep at the point it is used. It doesn't work. However when I try to rename cl in the following at the point of use, it works.

function init() {
    var cl = new mysql:Client("localhost", dbUser, dbPassword, "bookstore", 3306);
    if (cl is error) {
        panic cl; // renaming cl here works
    } else {
        db = cl;
    }
}

[nadeeshaan]

This is caused since the semantic API cannot get the ep symbol from the symbol() API when we give the cursor position as ep<cursor>. In this case the symbol identified is the service symbol. @pubudu91 @dulajdilshan We might need to have a fix for this as well.

[pubudu91]

This is caused since the semantic API cannot get the ep symbol from the symbol() API when we give the cursor position as ep<cursor>. In this case the symbol identified is the service symbol. @pubudu91 @dulajdilshan We might need to have a fix for this as well.

Why use ep<cursor> as the position to lookup the symbol though? 🤔

[nadeeshaan]

@pubudu91 This is the position we get from the client with the rename request.

[dulajdilshan]

I think #29586 (plugin-vscde) is also due to this.

[nadeeshaan]

I think #29586 (plugin-vscde) is also due to this.

Yes. This also have the same issue

[IMS94]

@pubudu91 If a user highlights a variable and do a rename, the cursor position sent by the client will be the position next last character of the var name. But with #28754, we did a temporary hack to fallback to cursor - 1. Not sure why it has not come into play if the cause is what @nadeeshaan mentions. 🤔

[nadeeshaan]

@IMS94 the fall back fix we did only works when we do not get a valid symbol (Optional.empty). But in these scenarios the node finder encloses the parent symbol and return it, in the sense we get a symbol instance, but incorrect. The temporary fall back method is reliable only for a limited subset