Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function visibility #3

Closed
isudana opened this issue Nov 21, 2016 · 3 comments
Closed

Function visibility #3

isudana opened this issue Nov 21, 2016 · 3 comments

Comments

@isudana
Copy link
Contributor

isudana commented Nov 21, 2016 •
edited

Currently all the functions are visible to everyone (anyone can import and use).
We have the requirement to make some of the functions private to the package (mainly for implementing connectors).
@isudana
Copy link
Contributor Author

isudana commented Nov 21, 2016 •
edited

Agreed on that we need visibility levels, yet to finalize keywords.

@isudana
Copy link
Contributor Author

isudana commented Nov 22, 2016 •
edited

Based on the discussion held on 21/11, our current state is as follows,

  • We need to have visibility levels.
  • All functions of a package is visible to everywhere in the same package
  • No relationship with files and visibility levels of functions, everything is decided based on the packages
  • By default no function is visible outside the package, if we want we can make them visible by adding keyword 'public' or similar keyword.
  • Keyword to make the function visible to outside is not yet finalized
  • Still we have no agreement on visibility of Resources, we know that it is visible to the external world, but not decided on whether we need visibility levels for Resources within Ballerina code.

@isudana
Copy link
Contributor Author

isudana commented Nov 22, 2016 •
edited

Keyword is "public"

Visibility of the Resources, is something we don't need to worry about as they are not callable.

@isudana isudana closed this as completed Nov 22, 2016
sumuditha-viraj pushed a commit that referenced this issue Jan 3, 2017
@sohaniwso2
Merge pull request #3 from wso2/master
f9d527b 
merge changes
maheeka pushed a commit that referenced this issue Feb 2, 2017
@NipunaMarcus
Merge pull request #3 from maheeka/connectors
af6e99c 
revert action-invocation-statement changes
sameerajayasoma pushed a commit that referenced this issue Feb 19, 2017
Merge pull request #3 from ballerinalang/master
206d1f5 
Update fork
Shan1024 referenced this issue in Shan1024/ballerina Feb 21, 2017
Merge pull request #3 from wso2/master
63aed21 
Update changes
Megala21 added a commit to Megala21/ballerina that referenced this issue Feb 22, 2017
@Megala21
Merge pull request ballerina-platform#3 from dilini-muthumala/test-ca…
abdb654 
…se-fixes

Removing parameter from file connector docs.
kasun04 pushed a commit that referenced this issue Mar 7, 2017
Merge pull request #3 from ballerinalang/master
339e4f1 
Update fork
lankavitharana pushed a commit that referenced this issue Jul 21, 2017
@sameerajayasoma
Merge pull request #3 from hasithaa/fix-interceptors
cbd4df4 
Update interceptors to read from balx and fix test failures.
@irunika irunika mentioned this issue Jul 24, 2017
Closed
irunika pushed a commit to irunika/ballerina that referenced this issue Aug 17, 2017
@shafreenAnfar
Merge pull request ballerina-platform#3 from irunika/transport-refactor
3ad6a86 
Transport Refactor
chamil321 referenced this issue in chamil321/ballerina Sep 8, 2017
@lankavitharana
Merge pull request #3 from chamil321/test-serverConnector
5c929fe 
Add request response signature annotations
chamil321 referenced this issue in chamil321/ballerina Oct 31, 2017
@pubudu91
Merge pull request #3 from chamil321/config-api
75db968 
Add default path for config file location
Shan1024 pushed a commit that referenced this issue Feb 6, 2018
@sameerajayasoma
Merge pull request #3 from ballerinalang/update-scope-name
6c868f4 
Update scope name
MaryamZi referenced this issue in MaryamZi/ballerina Mar 4, 2018
@gimantha
Merge pull request #3 from mohanvive/master
eccbe7b 
Where clause support for Ballerina Stream/Table
Anoukh referenced this issue in Anoukh/ballerina-lang Mar 5, 2018
@grainier
Merge pull request #3 from Anoukh/grainier-observability
488b2da 
Rename the function that gets all headers from mime:Entity
afkham added a commit that referenced this issue Mar 6, 2018
@afkham
Merge pull request #3 from anupama-pathirage/testBranchTrans
af8f714 
Fix transaction block id issue
MaryamZi referenced this issue in MaryamZi/ballerina Mar 6, 2018
@mohanvive
Merge pull request #3 from MaryamZi/stream-type
26ec789 
Introduce independent names for streams' topics
hasithaa pushed a commit that referenced this issue Jun 12, 2018
@SupunS
Merge pull request #3 from nadeeshaan/org-name-change
15773ac 
Fix Test Failures for orgName revamp
rasika referenced this issue in rasika/ballerina-lang Jun 19, 2018
@rasika
Fix for parsing erroneous tokens for Completions
a137882 
This fix make use of two extension points in the ANTLR default
ErrorHandler; reportMatch() and sync().

reportMatch() triggered per each successfull token match. When we are in
a token match this validates whether we're in the last terminating
token(i.e. '}','{',',',';').

Refer below example;

1. import ballerina/http;
2. import ballerina/io;
3. import ballerina/|

Suppose your cursor is at the end of the line #3. Your last terminating
token is the ';' in the line #2. If the current token of the parser is
above last terminating token; we'll remove/consume all future tokens
up to the current cursor position.

sync() triggered before any decision point in the parser. When we are in
a sync() hit; we'll analyze whether the cursor is just after the first
token of the cursor line. Whenever; sync hits before mentioned token it
will be removed/consumed by the CustomErrorStrategy.
nadeeshaan referenced this issue in nadeeshaan/ballerina Aug 29, 2018
Merge pull request #3 from nadeeshaan/update-docerina-local
2f03364 
Add signature help and hover support for new doc syntax
gimantha added a commit that referenced this issue Sep 20, 2018
@gimantha
Merge pull request #3 from grainier/join-desugar
0a531f4 
Refactor and add test cases streaming v2
Kishanthan pushed a commit that referenced this issue Dec 4, 2018
Merge pull request #3 from Shan1024/Anoukh-underscore
2be9cca 
Change OrderedHashSet to LinkedHashSet
anupama-pathirage pushed a commit that referenced this issue Dec 4, 2018
@ChinthakaSenanayaka
Merge pull request #3 from ballerina-platform/master
bfa8912 
Back Merge
hasithaa pushed a commit that referenced this issue Mar 30, 2019
@MaryamZi
Merge pull request #3 from NipunaMarcus/update-extern
040e67a 
Add formatting support for extern lang change
warunalakshitha pushed a commit that referenced this issue May 31, 2019
@chamil321
Merge pull request #3 from Kishanthan/http+io
affeca9 
BIR gen crypto, file, log, math, reflect and time modules
hasithaa added a commit that referenced this issue Aug 31, 2019
@hasithaa
Merge pull request #3 from rasika/hasithaa-lang_lib_update-2
f98d651 
Fix signature test failures
shafreenAnfar pushed a commit that referenced this issue Mar 12, 2020
@irshadnilam
Merge pull request #3 from rdhananjaya/xml-remove-old-on-xml-named-ty…
5ff5260 
…pes-pr

Xml remove old on xml named types pr
shafreenAnfar pushed a commit that referenced this issue Apr 2, 2020
@NipunaRanasinghe
Merge pull request #3 from ballerina-platform/ballerina-1.2.x
a78a3b0 
Sync with upstream
mohanvive added a commit that referenced this issue Apr 28, 2020
@mohanvive
Merge pull request #3 from gimantha/mohanvive-new-table-impl-2
6b339f6 
Fix type param issue
ldclakmal added a commit that referenced this issue May 12, 2020
@ldclakmal
Merge pull request #23169 from ldclakmal/bstring-migration-stdlib
3bcf85b 
StdLib Bstring Migration - PR #3
nadeeshaan referenced this issue in nadeeshaan/ballerina Jun 15, 2020
@rdhananjaya
Merge pull request #3 from nadeeshaan/icon-annotation-local
5d0fbd0 
Fix failing annotation completion tests
azinneera pushed a commit to azinneera/ballerina-lang that referenced this issue Oct 16, 2020
@hevayo
Merge pull request ballerina-platform#3 from sameerajayasoma/hevayo-p…
482f3e0 
…rj_api_module_refactor

Fix executable jar creation
CharukaK pushed a commit to CharukaK/ballerina that referenced this issue Dec 2, 2020
@NipunaMarcus
Merge pull request ballerina-platform#3 from srsharon/source-modifica…
2285b10 
…tion

Add category label to Ballerina connectors
rpjayasekara added a commit to rpjayasekara/ballerina-lang that referenced this issue Jun 25, 2021
@rpjayasekara
Merge branch 'master' of https://github.com/ballerina-platform/baller…
cd4bcfb 
…ina-lang into fix-ballerina-platform#3
rdhananjaya pushed a commit that referenced this issue Aug 30, 2021
@ushirask
Merge pull request #3 from ballerina-platform/jbal-semtype
f64577d 
merge from jbal-semtype branch
nadeeshaan added a commit that referenced this issue Nov 26, 2021
@nadeeshaan
Merge pull request #3 from NipunaMarcus/dev-branch-2
aa44b54 
Change diagnostic extension to use cloned project
anupama-pathirage pushed a commit that referenced this issue Jun 15, 2022
@madushajg
Merge pull request #3 from tharindulak/missing
9da610f 
Add resource and module part missing commits
dilanSachi added a commit that referenced this issue Nov 9, 2022
@dilanSachi
Merge pull request #3 from malinthar/sync-3.x
4e6c317 
Fix failing LS test
gimantha added a commit that referenced this issue Feb 20, 2023
@gimantha
Merge pull request #3 from KavinduZoysa/gimantha-table-issue
3c57ded 
Fix test failures in 38390
dulajdilshan added a commit that referenced this issue Mar 21, 2024
@dulajdilshan
Merge pull request #3 from ballerina-platform/master
448bd14 
Sync `master`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isudana