Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix BAL_CONFIG_DATA toml parsing not throwing parsing errors #40220

Closed
HindujaB opened this issue Apr 12, 2023 · 1 comment · Fixed by #40314
Closed

[Bug]: Fix BAL_CONFIG_DATA toml parsing not throwing parsing errors #40220

HindujaB opened this issue Apr 12, 2023 · 1 comment · Fixed by #40314
Assignees
Labels
BreakingChange Fix containing a backward incompatible change. Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Type/Bug

Comments

@HindujaB
Copy link
Contributor

Description

$subject

Steps to Reproduce

Currently, if we provide invalid TOML content through the Environment Variable, it throws value not provided errors for configurable instead of an Invalid TOML content error.
This is deviant from the TOML file passing behavior.

This is because we ignore the diagnostic logs from the Toml parser if we receive a valid toml node.

Affected Version(s)

current master

OS, DB, other environment details and versions

No response

Related area

-> Runtime

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@HindujaB HindujaB self-assigned this Apr 12, 2023
@ballerina-bot ballerina-bot added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Apr 12, 2023
@HindujaB HindujaB added the BreakingChange Fix containing a backward incompatible change. label Apr 12, 2023
@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@HindujaB HindujaB added the Reason/EngineeringMistake The issue occurred due to a mistake made in the past. label May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChange Fix containing a backward incompatible change. Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Type/Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants