Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BAL_CONFIG_DATA toml parsing not throwing parsing errors #40314

Merged

Conversation

HindujaB
Copy link
Contributor

Purpose

$subject

Fixes #40220

Approach

Used the same logic we use to handle the toml parser errors.

Samples

Remarks

CheckList

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@HindujaB HindujaB added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Apr 27, 2023
@HindujaB HindujaB added this to the 2201.7.0 milestone Apr 27, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -3.24 ⚠️

Comparison is base (2630f80) 80.40% compared to head (1f86b97) 77.16%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40314      +/-   ##
============================================
- Coverage     80.40%   77.16%   -3.24%     
+ Complexity    85050    54313   -30737     
============================================
  Files          3534     3340     -194     
  Lines        289317   201862   -87455     
  Branches      55282    25977   -29305     
============================================
- Hits         232611   155772   -76839     
+ Misses        48173    37612   -10561     
+ Partials       8533     8478      -55     
Impacted Files Coverage Δ
...ternal/configurable/providers/toml/ConfigToml.java 84.61% <77.77%> (+11.64%) ⬆️
...nfigurable/providers/toml/TomlContentProvider.java 84.61% <100.00%> (+2.26%) ⬆️

... and 821 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add these changes to breaking change in Release note.

Copy link
Contributor

@Nadeeshan96 Nadeeshan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha added the BreakingChange Fix containing a backward incompatible change. label May 17, 2023
@warunalakshitha warunalakshitha merged commit 2520010 into ballerina-platform:master May 29, 2023
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChange Fix containing a backward incompatible change. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix BAL_CONFIG_DATA toml parsing not throwing parsing errors
4 participants