-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BAL_CONFIG_DATA
toml parsing not throwing parsing errors
#40314
Fix BAL_CONFIG_DATA
toml parsing not throwing parsing errors
#40314
Conversation
… into fix-config-content
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #40314 +/- ##
============================================
- Coverage 80.40% 77.16% -3.24%
+ Complexity 85050 54313 -30737
============================================
Files 3534 3340 -194
Lines 289317 201862 -87455
Branches 55282 25977 -29305
============================================
- Hits 232611 155772 -76839
+ Misses 48173 37612 -10561
+ Partials 8533 8478 -55
☔ View full report in Codecov by Sentry. |
...na-integration-test/src/test/java/org/ballerinalang/test/configurables/ConfigurableTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add these changes to breaking change in Release note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2520010
into
ballerina-platform:master
Purpose
$subject
Fixes #40220
Approach
Used the same logic we use to handle the toml parser errors.
Samples
Remarks
CheckList