Disallow multi-line string literals #19164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pubudu91
added
the
Team/CompilerFE
Shan1024
reviewed
Sep 26, 2019
compiler/ballerina-lang/src/main/resources/grammar/BallerinaLexer.g4
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## ballerina-1.0.x #19164 +/- ##
================================================
Coverage 15.73% 15.73%
================================================
Files 47 47
Lines 1265 1265
Branches 197 197
================================================
Hits 199 199
Misses 1053 1053
Partials 13 13Continue to review full report at Codecov.
|
MaryamZi
approved these changes
Sep 27, 2019
| @@ -0,0 +1,31 @@ | |||
| // Copyright (c) 2019 WSO2 Inc. (http://www.wso2.org) All Rights Reserved. | |||
There was a problem hiding this comment.
Just for clarity, shall we rename this file to something like string_multi_line_negative.bal?
|
We need to update the standard library module.md pages and "how-to" pages in ballerina.io along with this change. |
|
@anupama-pathirage Fixed a usage in the Module.md of jdbc module. Created https://github.com/ballerina-platform/ballerina-www/issues/1642 for checking the how-to pages. |
anupama-pathirage
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #19142
Check List